[spring-extensions] 01/03: IDP-1047 Cleanup prior to using in our configurations

Rod Widdowson rdw at steadingsoftware.com
Tue Oct 4 09:00:14 EDT 2016


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository spring-extensions.

View the commit online:
http://git.shibboleth.net/view/?p=spring-extensions.git;a=commit;h=8719278582dad8bb7d7a16ffb5c4668f7e8e8611

commit 8719278582dad8bb7d7a16ffb5c4668f7e8e8611
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Oct 4 13:51:21 2016 +0100

    IDP-1047 Cleanup prior to using in our configurations
    
    https://issues.shibboleth.net/jira/browse/IDP-1047
    
    Given that we will probably not be able to cover all bases in 3.3, turn
    the warn down to debug.  In many cases there is nothing a deployer can
    do to mitigate this error so a warning is harsh.
---
 .../ext/spring/util/AnnotationParameterNameDiscoverer.java       | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/main/java/net/shibboleth/ext/spring/util/AnnotationParameterNameDiscoverer.java b/src/main/java/net/shibboleth/ext/spring/util/AnnotationParameterNameDiscoverer.java
index d552bc2..499cd1c 100644
--- a/src/main/java/net/shibboleth/ext/spring/util/AnnotationParameterNameDiscoverer.java
+++ b/src/main/java/net/shibboleth/ext/spring/util/AnnotationParameterNameDiscoverer.java
@@ -91,11 +91,10 @@ public class AnnotationParameterNameDiscoverer extends DefaultParameterNameDisco
         }
 
         if (!allPresent) {
-            if (isOurs) {
-                log.warn("Constructor for class '{}' with {} parameters: "
-                        + "Not all parameters are annotated with @ParameterName", className, annotationsArray.length);
-                log.debug("Types : {}", (Object)ctor.getParameterTypes());
-            }
+
+            log.debug("Constructor for class '{}' with {} parameters: "
+                    + "Not all parameters are annotated with @ParameterName", className, annotationsArray.length);
+            log.debug("Types : {}", (Object)ctor.getParameterTypes());
             return super.getParameterNames(ctor);
         }
         log.trace("Constructor for class '{}' with {} parameters called {}", className, names.length, names);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list