[java-identity-provider COMMIT] in /trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute: IdPAttribute....
noreply at shibboleth.net
noreply at shibboleth.net
Mon Oct 3 05:34:36 EDT 2016
Author: rdw
Date: Mon Oct 3 05:34:34 2016
New Revision: 8451
URL: http://svn.shibboleth.net/view/java-identity-provider?rev=8451&view=rev
Log:
IDP-1047 Add parameter name annotation to attribute-api classes
https://issues.shibboleth.net/jira/browse/IDP-1047
Modified:
trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java
trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/LocalizedStringAttributeValue.java
trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ScopedStringAttributeValue.java
trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/StringAttributeValue.java
trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/XMLObjectAttributeValue.java
Modified: trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java?rev=8451&r1=8450&r2=8451&view=diff
==============================================================================
--- trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java (original)
+++ trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java Mon Oct 3 05:34:34 2016
@@ -29,6 +29,7 @@
import javax.annotation.Nullable;
import javax.annotation.concurrent.NotThreadSafe;
+import net.shibboleth.utilities.java.support.annotation.ParameterName;
import net.shibboleth.utilities.java.support.annotation.constraint.NonnullElements;
import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
import net.shibboleth.utilities.java.support.annotation.constraint.NullableElements;
@@ -74,7 +75,8 @@
*
* @param attributeId unique identifier of the attribute
*/
- public IdPAttribute(@Nonnull @NotEmpty final String attributeId) {
+ public IdPAttribute(@Nonnull @NotEmpty @ParameterName(name="attributeId") final String attributeId) {
+
id = Constraint.isNotNull(StringSupport.trimOrNull(attributeId), "Attribute ID may not be null");
displayNames = Collections.emptyMap();
Modified: trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/LocalizedStringAttributeValue.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/LocalizedStringAttributeValue.java?rev=8451&r1=8450&r2=8451&view=diff
==============================================================================
--- trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/LocalizedStringAttributeValue.java (original)
+++ trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/LocalizedStringAttributeValue.java Mon Oct 3 05:34:34 2016
@@ -22,6 +22,7 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
+import net.shibboleth.utilities.java.support.annotation.ParameterName;
import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
import com.google.common.base.MoreObjects;
@@ -39,8 +40,9 @@
* @param attributeValue the value of the attribute
* @param attributeValueLocale the locale of the attribute value
*/
- public LocalizedStringAttributeValue(@Nonnull @NotEmpty final String attributeValue,
- @Nullable final Locale attributeValueLocale) {
+ public LocalizedStringAttributeValue(
+ @Nonnull @NotEmpty @ParameterName(name="attributeValue") final String attributeValue,
+ @Nullable @ParameterName(name="attributeValueLocale") final Locale attributeValueLocale) {
super(attributeValue);
valueLocale = attributeValueLocale;
}
Modified: trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ScopedStringAttributeValue.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ScopedStringAttributeValue.java?rev=8451&r1=8450&r2=8451&view=diff
==============================================================================
--- trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ScopedStringAttributeValue.java (original)
+++ trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/ScopedStringAttributeValue.java Mon Oct 3 05:34:34 2016
@@ -21,6 +21,7 @@
import javax.annotation.Nullable;
import javax.annotation.concurrent.ThreadSafe;
+import net.shibboleth.utilities.java.support.annotation.ParameterName;
import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
import net.shibboleth.utilities.java.support.logic.Constraint;
import net.shibboleth.utilities.java.support.primitive.StringSupport;
@@ -41,8 +42,9 @@
* @param attributeValue the value of the attribute
* @param valueScope scope of the value
*/
- public ScopedStringAttributeValue(@Nonnull @NotEmpty final String attributeValue,
- @Nonnull @NotEmpty final String valueScope) {
+ public ScopedStringAttributeValue(
[... 52 lines stripped ...]
More information about the commits
mailing list