[spring-extensions] 08/10: JPAR-85 - Add missing final keyword to local variables.
Tom Zeller
tzeller at dragonacea.biz
Mon May 16 21:56:54 EDT 2016
This is an automated email from the git hooks/post-receive script.
tzeller pushed a commit to branch JPAR-85
in repository spring-extensions.
commit a4e0f9c28751ce558a3ef9463a04b2720478c4f5
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Mon May 16 20:54:57 2016 -0500
JPAR-85 - Add missing final keyword to local variables.
---
.../factory/FileCachingHttpClientFactoryBean.java | 4 ++--
.../ext/spring/resource/FileBackedHTTPResource.java | 4 ++--
.../shibboleth/ext/spring/resource/HTTPResource.java | 20 ++++++++++----------
.../shibboleth/ext/spring/resource/SVNResource.java | 6 +++---
.../ext/spring/service/ReloadableSpringService.java | 4 ++--
.../ext/spring/util/BaseSpringNamespaceHandler.java | 2 +-
.../SchemaTypeAwareBeanDefinitionDocumentReader.java | 2 +-
.../SchemaTypeAwareBeanDefinitionParserDelegate.java | 2 +-
.../shibboleth/ext/spring/util/SpringSupport.java | 4 ++--
9 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/src/main/java/net/shibboleth/ext/spring/factory/FileCachingHttpClientFactoryBean.java b/src/main/java/net/shibboleth/ext/spring/factory/FileCachingHttpClientFactoryBean.java
index c6b3a1c..3daa2ab 100644
--- a/src/main/java/net/shibboleth/ext/spring/factory/FileCachingHttpClientFactoryBean.java
+++ b/src/main/java/net/shibboleth/ext/spring/factory/FileCachingHttpClientFactoryBean.java
@@ -79,10 +79,10 @@ public class FileCachingHttpClientFactoryBean extends HttpClientFactoryBean impl
/** {@inheritDoc} */
@Override
protected HttpClient doCreateInstance() throws Exception {
- HttpClient client = super.doCreateInstance();
+ final HttpClient client = super.doCreateInstance();
synchronized(this) {
if (client instanceof InitializableComponent) {
- InitializableComponent component = (InitializableComponent) client;
+ final InitializableComponent component = (InitializableComponent) client;
if (!component.isInitialized()) {
component.initialize();
}
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java b/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java
index b9a7b79..428d6a5 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java
@@ -132,7 +132,7 @@ public class FileBackedHTTPResource extends HTTPResource {
*/
protected InputStream saveAndClone(final InputStream input) throws IOException {
- FileOutputStream out = new FileOutputStream(backingResource.getFile());
+ final FileOutputStream out = new FileOutputStream(backingResource.getFile());
try {
log.debug("{}: Copying file.", getDescription());
ByteStreams.copy(input, out);
@@ -177,7 +177,7 @@ public class FileBackedHTTPResource extends HTTPResource {
log.info("{}: Could not reach URL, trying file", getDescription(), e);
return backingResource.exists();
}
- int httpStatusCode = response.getStatusLine().getStatusCode();
+ final int httpStatusCode = response.getStatusLine().getStatusCode();
if (httpStatusCode == HttpStatus.SC_OK) {
return true;
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java b/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
index 810680b..3a3c82b 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
@@ -109,7 +109,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
* @return a new instance of {@link HttpCacheContext}
*/
protected HttpCacheContext buildHttpClientContext() {
- HttpCacheContext context = HttpCacheContext.create();
+ final HttpCacheContext context = HttpCacheContext.create();
if (credentialsProvider != null) {
context.setCredentialsProvider(credentialsProvider);
}
@@ -122,7 +122,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
* @param context the context of the request
*/
protected void reportCachingStatus(final HttpCacheContext context) {
- CacheResponseStatus responseStatus = context.getCacheResponseStatus();
+ final CacheResponseStatus responseStatus = context.getCacheResponseStatus();
if (null == responseStatus) {
log.debug("Non caching client provided");
return;
@@ -156,10 +156,10 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
log.debug("Attempting to get data from remote resource '{}'", resourceURL);
response = httpClient.execute(httpGet, context);
reportCachingStatus(context);
- int httpStatusCode = response.getStatusLine().getStatusCode();
+ final int httpStatusCode = response.getStatusLine().getStatusCode();
if (httpStatusCode != HttpStatus.SC_OK) {
- String errMsg =
+ final String errMsg =
"Non-ok status code " + httpStatusCode + " returned from remote resource " + resourceURL;
log.error(errMsg);
closeResponse(response);
@@ -189,7 +189,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
} catch (final IOException e) {
return false;
}
- int httpStatusCode = response.getStatusLine().getStatusCode();
+ final int httpStatusCode = response.getStatusLine().getStatusCode();
return httpStatusCode == HttpStatus.SC_OK;
}
@@ -233,7 +233,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
* @throws IOException thrown if there is a problem contacting the resource
*/
protected HttpResponse getResourceHeaders() throws IOException {
- HttpUriRequest httpRequest = new HttpGet(resourceURL.toExternalForm());
+ final HttpUriRequest httpRequest = new HttpGet(resourceURL.toExternalForm());
HttpResponse httpResponse = null;
try {
@@ -261,7 +261,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
log.debug("Attempting to fetch remote resource as '{}'", resourceURL);
response = getResourceHeaders();
- int httpStatusCode = response.getStatusLine().getStatusCode();
+ final int httpStatusCode = response.getStatusLine().getStatusCode();
if (httpStatusCode != HttpStatus.SC_OK) {
final String errMsg =
@@ -280,7 +280,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
/** {@inheritDoc} */
@Override public long contentLength() throws IOException {
- String response = getResponseHeader(HttpHeaders.CONTENT_LENGTH);
+ final String response = getResponseHeader(HttpHeaders.CONTENT_LENGTH);
if (null != response) {
return Long.parseLong(response);
}
@@ -292,7 +292,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
/** {@inheritDoc} */
@Override public long lastModified() throws IOException {
- String response = getResponseHeader(HttpHeaders.LAST_MODIFIED);
+ final String response = getResponseHeader(HttpHeaders.LAST_MODIFIED);
if (null != response) {
return DateUtils.parseDate(response).getTime();
}
@@ -304,7 +304,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
/** {@inheritDoc} Based on {@link org.springframework.core.io.UrlResource}. */
@Override public HTTPResource createRelative(final String relativePath) throws IOException {
- String path;
+ final String path;
if (relativePath.startsWith("/")) {
path = relativePath.substring(1);
} else {
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java b/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java
index f9f2a86..17d923e 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java
@@ -194,7 +194,7 @@ public class SVNResource extends AbstractIdentifiedInitializableComponent implem
}
if (!directory.exists()) {
- boolean created = directory.mkdirs();
+ final boolean created = directory.mkdirs();
if (!created) {
final String msg = "SVN working copy directory " + directory.getAbsolutePath()
+ " does not exist and could not be created";
@@ -234,7 +234,7 @@ public class SVNResource extends AbstractIdentifiedInitializableComponent implem
*/
protected void checkoutOrUpdateResource() throws IOException {
log.debug("checking out or updating working copy");
- SVNRevision newRevision;
+ final SVNRevision newRevision;
if (!workingCopyDirectoryExists()) {
log.debug("Working copy does not yet exist, checking it out to {}", workingCopyDirectory.getAbsolutePath());
@@ -426,7 +426,7 @@ public class SVNResource extends AbstractIdentifiedInitializableComponent implem
/** {@inheritDoc} */
@Override public String getDescription() {
- StringBuffer sb = new StringBuffer("SVN Resource: ");
+ final StringBuffer sb = new StringBuffer("SVN Resource: ");
return sb.append(getFullPath()).toString();
}
diff --git a/src/main/java/net/shibboleth/ext/spring/service/ReloadableSpringService.java b/src/main/java/net/shibboleth/ext/spring/service/ReloadableSpringService.java
index 2649e02..8578b74 100644
--- a/src/main/java/net/shibboleth/ext/spring/service/ReloadableSpringService.java
+++ b/src/main/java/net/shibboleth/ext/spring/service/ReloadableSpringService.java
@@ -176,7 +176,7 @@ public class ReloadableSpringService<T> extends AbstractReloadableService<T> imp
if (!serviceConfigurations.isEmpty()) {
resourceLastModifiedTimes = new long[serviceConfigurations.size()];
- int numOfResources = serviceConfigurations.size();
+ final int numOfResources = serviceConfigurations.size();
Resource serviceConfig;
for (int i = 0; i < numOfResources; i++) {
serviceConfig = serviceConfigurations.get(i);
@@ -273,7 +273,7 @@ public class ReloadableSpringService<T> extends AbstractReloadableService<T> imp
}
boolean configResourceChanged = false;
- int numOfResources = serviceConfigurations.size();
+ final int numOfResources = serviceConfigurations.size();
Resource serviceConfig;
long serviceConfigLastModified;
diff --git a/src/main/java/net/shibboleth/ext/spring/util/BaseSpringNamespaceHandler.java b/src/main/java/net/shibboleth/ext/spring/util/BaseSpringNamespaceHandler.java
index a9ad660..32c31b0 100644
--- a/src/main/java/net/shibboleth/ext/spring/util/BaseSpringNamespaceHandler.java
+++ b/src/main/java/net/shibboleth/ext/spring/util/BaseSpringNamespaceHandler.java
@@ -108,7 +108,7 @@ public abstract class BaseSpringNamespaceHandler implements NamespaceHandler {
protected BeanDefinitionParser findParserForElement(final Element element) {
BeanDefinitionParser parser = null;
- QName typeName = DOMTypeSupport.getXSIType(element);
+ final QName typeName = DOMTypeSupport.getXSIType(element);
if (typeName != null) {
log.trace("Attempting to find parser for element of type: {}", typeName);
parser = parsers.get(typeName);
diff --git a/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionDocumentReader.java b/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionDocumentReader.java
index f75757b..a12b7e9 100644
--- a/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionDocumentReader.java
+++ b/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionDocumentReader.java
@@ -32,7 +32,7 @@ public class SchemaTypeAwareBeanDefinitionDocumentReader extends DefaultBeanDefi
@Override
protected BeanDefinitionParserDelegate createDelegate(final XmlReaderContext readerContext, final Element root,
final BeanDefinitionParserDelegate parentDelegate) {
- BeanDefinitionParserDelegate delegate =
+ final BeanDefinitionParserDelegate delegate =
new SchemaTypeAwareBeanDefinitionParserDelegate(readerContext);
delegate.initDefaults(root, parentDelegate);
return delegate;
diff --git a/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionParserDelegate.java b/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionParserDelegate.java
index f765c99..0f02471 100644
--- a/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionParserDelegate.java
+++ b/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionParserDelegate.java
@@ -57,7 +57,7 @@ public class SchemaTypeAwareBeanDefinitionParserDelegate extends BeanDefinitionP
namespaceUri = DOMTypeSupport.getXSIType(element).getNamespaceURI();
}
- NamespaceHandler handler = getReaderContext().getNamespaceHandlerResolver().resolve(namespaceUri);
+ final NamespaceHandler handler = getReaderContext().getNamespaceHandlerResolver().resolve(namespaceUri);
if (handler == null) {
error("Unable to locate NamespaceHandler for namespace [" + namespaceUri + "]", element);
return null;
diff --git a/src/main/java/net/shibboleth/ext/spring/util/SpringSupport.java b/src/main/java/net/shibboleth/ext/spring/util/SpringSupport.java
index d5dd647..5d7260d 100644
--- a/src/main/java/net/shibboleth/ext/spring/util/SpringSupport.java
+++ b/src/main/java/net/shibboleth/ext/spring/util/SpringSupport.java
@@ -151,7 +151,7 @@ public final class SpringSupport {
return null;
}
- ManagedList<BeanDefinition> definitions = new ManagedList<>(elements.size());
+ final ManagedList<BeanDefinition> definitions = new ManagedList<>(elements.size());
for (Element e : elements) {
if (e != null) {
definitions.add(parseCustomElement(e, parserContext));
@@ -259,7 +259,7 @@ public final class SpringSupport {
* @return list of values, never null
*/
@Nonnull public static ManagedList<String> getAttributeValueAsManagedList(@Nullable final Attr attribute) {
- List<String> valuesAsList = AttributeSupport.getAttributeValueAsList(attribute);
+ final List<String> valuesAsList = AttributeSupport.getAttributeValueAsList(attribute);
final ManagedList<String> managedList = new ManagedList<>(valuesAsList.size());
managedList.addAll(valuesAsList);
return managedList;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list