[spring-extensions] 04/10: JPAR-85 - Add missing final keywords to parameters in constructors.
Tom Zeller
tzeller at dragonacea.biz
Mon May 16 21:56:50 EDT 2016
This is an automated email from the git hooks/post-receive script.
tzeller pushed a commit to branch JPAR-85
in repository spring-extensions.
commit 01c5a97b020e0f88d6590d53ae01d2ef605f0579
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Mon May 16 20:48:44 2016 -0500
JPAR-85 - Add missing final keywords to parameters in constructors.
---
.../context/FilesystemGenericApplicationContext.java | 7 ++++---
.../ext/spring/error/ExtendedMappingExceptionResolver.java | 2 +-
.../ext/spring/resource/FileBackedHTTPResource.java | 14 ++++++++------
.../net/shibboleth/ext/spring/resource/HTTPResource.java | 6 +++---
.../net/shibboleth/ext/spring/resource/ResourceHelper.java | 2 +-
.../ext/spring/resource/SVNBasicAuthenticationManager.java | 7 ++++---
.../net/shibboleth/ext/spring/resource/SVNResource.java | 5 +++--
.../ext/spring/service/ReloadableSpringService.java | 6 +++---
.../util/SchemaTypeAwareBeanDefinitionParserDelegate.java | 2 +-
.../util/SchemaTypeAwareXMLBeanDefinitionReader.java | 2 +-
10 files changed, 29 insertions(+), 24 deletions(-)
diff --git a/src/main/java/net/shibboleth/ext/spring/context/FilesystemGenericApplicationContext.java b/src/main/java/net/shibboleth/ext/spring/context/FilesystemGenericApplicationContext.java
index e2a4ced..dfde0e1 100644
--- a/src/main/java/net/shibboleth/ext/spring/context/FilesystemGenericApplicationContext.java
+++ b/src/main/java/net/shibboleth/ext/spring/context/FilesystemGenericApplicationContext.java
@@ -39,7 +39,7 @@ public class FilesystemGenericApplicationContext extends GenericApplicationConte
*
* @param beanFactory bean factory
*/
- public FilesystemGenericApplicationContext(DefaultListableBeanFactory beanFactory) {
+ public FilesystemGenericApplicationContext(final DefaultListableBeanFactory beanFactory) {
super(beanFactory);
}
@@ -48,7 +48,7 @@ public class FilesystemGenericApplicationContext extends GenericApplicationConte
*
* @param parent parent context
*/
- public FilesystemGenericApplicationContext(ApplicationContext parent) {
+ public FilesystemGenericApplicationContext(final ApplicationContext parent) {
super(parent);
}
@@ -58,7 +58,8 @@ public class FilesystemGenericApplicationContext extends GenericApplicationConte
* @param beanFactory bean factory
* @param parent parent context
*/
- public FilesystemGenericApplicationContext(DefaultListableBeanFactory beanFactory, ApplicationContext parent) {
+ public FilesystemGenericApplicationContext(final DefaultListableBeanFactory beanFactory,
+ final ApplicationContext parent) {
super(beanFactory, parent);
}
diff --git a/src/main/java/net/shibboleth/ext/spring/error/ExtendedMappingExceptionResolver.java b/src/main/java/net/shibboleth/ext/spring/error/ExtendedMappingExceptionResolver.java
index 322d64a..692220a 100644
--- a/src/main/java/net/shibboleth/ext/spring/error/ExtendedMappingExceptionResolver.java
+++ b/src/main/java/net/shibboleth/ext/spring/error/ExtendedMappingExceptionResolver.java
@@ -65,7 +65,7 @@ public class ExtendedMappingExceptionResolver extends SimpleMappingExceptionReso
*
* @param extender function to obtain extensions to view model
*/
- public ExtendedMappingExceptionResolver(@Nonnull Function<HttpServletRequest,Map<String,Object>> extender) {
+ public ExtendedMappingExceptionResolver(@Nonnull final Function<HttpServletRequest,Map<String,Object>> extender) {
viewModelExtenderFunction = Constraint.isNotNull(extender, "Extender function cannot be null");
}
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java b/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java
index c0d381f..ad9221c 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java
@@ -61,8 +61,8 @@ public class FileBackedHTTPResource extends HTTPResource {
* @param resource the file to use as backing store
* @throws IOException if the URL was badly formed
* @deprecated use {@link #FileBackedHTTPResource(String, HttpClient, String) */
- @Deprecated public FileBackedHTTPResource(@Nonnull HttpClient client, @NotEmpty @Nonnull String url,
- @Nonnull Resource resource) throws IOException {
+ @Deprecated public FileBackedHTTPResource(@Nonnull final HttpClient client, @NotEmpty @Nonnull final String url,
+ @Nonnull final Resource resource) throws IOException {
super(client, url);
backingResource = Constraint.isNotNull(resource, "Backing resource must not be null");
if (null == resource.getFile()) {
@@ -80,7 +80,8 @@ public class FileBackedHTTPResource extends HTTPResource {
* @param resource the file to use as backing store
* @throws IOException if the URL was badly formed
* @deprecated use {@link #FileBackedHTTPResource(String, HttpClient, URL) */
- @Deprecated public FileBackedHTTPResource(@Nonnull HttpClient client, @Nonnull URL url, @Nonnull Resource resource)
+ @Deprecated public FileBackedHTTPResource(@Nonnull final HttpClient client, @Nonnull final URL url,
+ @Nonnull final Resource resource)
throws IOException {
super(client, url);
backingResource = Constraint.isNotNull(resource, "Backing resource must not be null");
@@ -97,8 +98,8 @@ public class FileBackedHTTPResource extends HTTPResource {
* @param url URL to the remote data
* @throws IOException if the URL was badly formed
*/
- public FileBackedHTTPResource(@Nonnull String backingFile, @Nonnull HttpClient client,
- @NotEmpty @Nonnull String url) throws IOException {
+ public FileBackedHTTPResource(@Nonnull final String backingFile, @Nonnull final HttpClient client,
+ @NotEmpty @Nonnull final String url) throws IOException {
super(client, url);
Constraint.isNotNull(backingFile, "File Name must not be null");
final File file = new File(backingFile);
@@ -113,7 +114,8 @@ public class FileBackedHTTPResource extends HTTPResource {
* @param url URL to the remote data
* @throws IOException if the URL was badly formed
*/
- public FileBackedHTTPResource(@Nonnull String backingFile, @Nonnull HttpClient client, @Nonnull URL url)
+ public FileBackedHTTPResource(@Nonnull final String backingFile, @Nonnull final HttpClient client,
+ @Nonnull final URL url)
throws IOException {
super(client, url);
Constraint.isNotNull(backingFile, "File Name must not be null");
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java b/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
index bc0b18e..8cdeff2 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
@@ -82,7 +82,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
* @param url URL to the remote data
* @throws IOException if the URL was badly formed
*/
- public HTTPResource(@Nonnull HttpClient client, @NotEmpty @Nonnull String url) throws IOException {
+ public HTTPResource(@Nonnull final HttpClient client, @NotEmpty @Nonnull final String url) throws IOException {
httpClient = Constraint.isNotNull(client, "The Client must not be null");
final String trimmedAddress =
Constraint.isNotNull(StringSupport.trimOrNull(url), "Provided URL must be non empty and non null");
@@ -97,7 +97,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
* @param url URL to the remote data
* @throws IOException if the URL was badly formed
*/
- public HTTPResource(@Nonnull HttpClient client, @Nonnull URL url) throws IOException {
+ public HTTPResource(@Nonnull final HttpClient client, @Nonnull final URL url) throws IOException {
httpClient = Constraint.isNotNull(client, "The Client must not be null");
resourceURL = Constraint.isNotNull(url, "Provided URL must be non empty and non null");
@@ -370,7 +370,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
* @param httpResponse HTTP method that was invoked
* @throws IOException if there is a problem getting the entity content input stream from the response
*/
- public ConnectionClosingInputStream(HttpResponse httpResponse) throws IOException {
+ public ConnectionClosingInputStream(final HttpResponse httpResponse) throws IOException {
response = httpResponse;
stream = response.getEntity().getContent();
}
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/ResourceHelper.java b/src/main/java/net/shibboleth/ext/spring/resource/ResourceHelper.java
index c7cf5af..e9360bc 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/ResourceHelper.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/ResourceHelper.java
@@ -42,7 +42,7 @@ public final class ResourceHelper implements net.shibboleth.utilities.java.suppo
*
* @param theResource the spring resource;
*/
- private ResourceHelper(@Nonnull Resource theResource) {
+ private ResourceHelper(@Nonnull final Resource theResource) {
springResource = Constraint.isNotNull(theResource, "provided Spring Resource should not be null");
}
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/SVNBasicAuthenticationManager.java b/src/main/java/net/shibboleth/ext/spring/resource/SVNBasicAuthenticationManager.java
index d105f93..4798ceb 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/SVNBasicAuthenticationManager.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/SVNBasicAuthenticationManager.java
@@ -53,7 +53,7 @@ public class SVNBasicAuthenticationManager extends BasicAuthenticationManager im
*
* @param authentications authentications
*/
- public SVNBasicAuthenticationManager(List<SVNAuthentication> authentications) {
+ public SVNBasicAuthenticationManager(final List<SVNAuthentication> authentications) {
super(authentications.toArray(new SVNAuthentication[authentications.size()]));
}
@@ -65,7 +65,8 @@ public class SVNBasicAuthenticationManager extends BasicAuthenticationManager im
* @param passphrase a password to the private key
* @param portNumber a port number over which an ssh tunnel is established
*/
- public SVNBasicAuthenticationManager(String userName, File keyFile, String passphrase, int portNumber) {
+ public SVNBasicAuthenticationManager(final String userName, final File keyFile, final String passphrase,
+ final int portNumber) {
super(userName, keyFile, passphrase, portNumber);
}
@@ -75,7 +76,7 @@ public class SVNBasicAuthenticationManager extends BasicAuthenticationManager im
* @param userName a userName
* @param password a password
*/
- public SVNBasicAuthenticationManager(String userName, String password) {
+ public SVNBasicAuthenticationManager(final String userName, final String password) {
super(userName, password);
}
diff --git a/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java b/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java
index 7c792ee..b4f99b6 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/SVNResource.java
@@ -95,8 +95,9 @@ public class SVNResource extends AbstractIdentifiedInitializableComponent implem
*
* @throws BeanCreationException thrown if there is a problem initializing the SVN resource
*/
- public SVNResource(SVNClientManager svnClientMgr, SVNURL repositoryUrl, File workingCopy, long workingRevision,
- String resourceFile) {
+ public SVNResource(final SVNClientManager svnClientMgr, final SVNURL repositoryUrl, final File workingCopy,
+ final long workingRevision,
+ final String resourceFile) {
DAVRepositoryFactory.setup();
SVNRepositoryFactoryImpl.setup();
FSRepositoryFactory.setup();
diff --git a/src/main/java/net/shibboleth/ext/spring/service/ReloadableSpringService.java b/src/main/java/net/shibboleth/ext/spring/service/ReloadableSpringService.java
index 4ecd62a..f9f9841 100644
--- a/src/main/java/net/shibboleth/ext/spring/service/ReloadableSpringService.java
+++ b/src/main/java/net/shibboleth/ext/spring/service/ReloadableSpringService.java
@@ -111,7 +111,7 @@ public class ReloadableSpringService<T> extends AbstractReloadableService<T> imp
*
* @param claz The interface being implemented.
*/
- public ReloadableSpringService(@Nonnull Class<T> claz) {
+ public ReloadableSpringService(@Nonnull final Class<T> claz) {
this(claz, new ClassBasedServiceStrategy());
}
@@ -121,8 +121,8 @@ public class ReloadableSpringService<T> extends AbstractReloadableService<T> imp
* @param claz The interface being implemented.
* @param strategy the strategy to use to look up servicable component to look for.
*/
- public ReloadableSpringService(@Nonnull Class<T> claz,
- @Nonnull Function<GenericApplicationContext, ServiceableComponent> strategy) {
+ public ReloadableSpringService(@Nonnull final Class<T> claz,
+ @Nonnull final Function<GenericApplicationContext, ServiceableComponent> strategy) {
theClaz = Constraint.isNotNull(claz, "Class cannot be null");
serviceStrategy = Constraint.isNotNull(strategy, "Strategy cannot be null");
factoryPostProcessors = Collections.emptyList();
diff --git a/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionParserDelegate.java b/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionParserDelegate.java
index ef5eea1..f765c99 100644
--- a/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionParserDelegate.java
+++ b/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareBeanDefinitionParserDelegate.java
@@ -39,7 +39,7 @@ public class SchemaTypeAwareBeanDefinitionParserDelegate extends BeanDefinitionP
*
* @param readerContext current XML reader context
*/
- public SchemaTypeAwareBeanDefinitionParserDelegate(XmlReaderContext readerContext) {
+ public SchemaTypeAwareBeanDefinitionParserDelegate(final XmlReaderContext readerContext) {
super(readerContext);
}
diff --git a/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareXMLBeanDefinitionReader.java b/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareXMLBeanDefinitionReader.java
index 4a21402..388366a 100644
--- a/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareXMLBeanDefinitionReader.java
+++ b/src/main/java/net/shibboleth/ext/spring/util/SchemaTypeAwareXMLBeanDefinitionReader.java
@@ -35,7 +35,7 @@ public class SchemaTypeAwareXMLBeanDefinitionReader extends XmlBeanDefinitionRea
*
* @param beanRegistry the bean definition registry that will be populated by this reader
*/
- public SchemaTypeAwareXMLBeanDefinitionReader(BeanDefinitionRegistry beanRegistry) {
+ public SchemaTypeAwareXMLBeanDefinitionReader(final BeanDefinitionRegistry beanRegistry) {
super(beanRegistry);
setDocumentReaderClass(SchemaTypeAwareBeanDefinitionDocumentReader.class);
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list