[js-embedded-discovery] branch master updated: EDS-73 Cookie Bypass: Default the radio buttons correctly

Rod Widdowson rdw at steadingsoftware.com
Thu May 12 10:42:44 EDT 2016


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository js-embedded-discovery.

The following commit(s) were added to refs/heads/master by this push:
       new  f79212f   EDS-73 Cookie Bypass: Default the radio buttons correctly
f79212f is described below

commit f79212f0dcaf3fdbdd0a854e663b82954c2e5152
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Thu May 12 13:29:10 2016 +0100

    EDS-73 Cookie Bypass: Default the radio buttons correctly
    
    https://issues.shibboleth.net/jira/browse/EDS-73
    
    As per Scott's feedback: make "the follow this selection <Never>"
    radio button the default.
---
 src/javascript/idpselect.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/javascript/idpselect.js b/src/javascript/idpselect.js
index 290c989..6e2da56 100644
--- a/src/javascript/idpselect.js
+++ b/src/javascript/idpselect.js
@@ -984,7 +984,7 @@ function IdPSelectUI() {
         //
         var but = document.createElement('input');
         but.setAttribute('type', 'radio');
-        but.setAttribute('checked', '');
+        but.setAttribute('checked', 'checked');
         but.setAttribute('name', inputName);
         but.onclick = function () {
             setAutoDispatchCookie(0);
@@ -1002,7 +1002,6 @@ function IdPSelectUI() {
             //
             but = document.createElement('input');
             but.setAttribute('type', 'radio');
-            but.setAttribute('checked', '');
             but.setAttribute('name', inputName);
 
             but.life = autoFollowCookieTTLs[i];

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list