[java-identity-provider COMMIT] /trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/profile/impl/PopulateBindi...

noreply at shibboleth.net noreply at shibboleth.net
Tue Mar 1 13:55:33 EST 2016


Author: scantor
Date: Tue Mar  1 13:55:32 2016
New Revision: 8111

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=8111&view=rev
Log:
IDP-898 - improve logging for PopulateBindingAndEndpointContexts

https://issues.shibboleth.net/jira/browse/IDP-898

Modified:
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/profile/impl/PopulateBindingAndEndpointContexts.java

Modified: trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/profile/impl/PopulateBindingAndEndpointContexts.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/profile/impl/PopulateBindingAndEndpointContexts.java?rev=8111&r1=8110&r2=8111&view=diff
==============================================================================
--- trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/profile/impl/PopulateBindingAndEndpointContexts.java	(original)
+++ trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/profile/impl/PopulateBindingAndEndpointContexts.java	Tue Mar  1 13:55:32 2016
@@ -137,6 +137,9 @@
     /** Optional inbound message. */
     @Nullable private Object inboundMessage;
     
+    /** Optional RP name for logging. */
+    @Nullable private String relyingPartyId;
+    
     /** Optional metadata for use in endpoint derivation/validation. */
     @Nullable private SAMLMetadataContext mdContext;
 
@@ -327,6 +330,7 @@
         
         final RelyingPartyContext rpContext = relyingPartyContextLookupStrategy.apply(profileRequestContext);
         if (rpContext != null) {
+            relyingPartyId = rpContext.getRelyingPartyId();
             verified = rpContext.isVerified();
             if (rpContext.getProfileConfig() != null
                     && rpContext.getProfileConfig() instanceof SAMLProfileConfiguration) {
@@ -401,7 +405,8 @@
         }
         
         if (resolvedEndpoint == null) {
-            log.warn("{} Unable to resolve outbound message endpoint", getLogPrefix());
+            log.warn("{} Unable to resolve outbound message endpoint for relying party '{}': {}",
+                    getLogPrefix(), relyingPartyId, criteria.get(EndpointCriterion.class));
             ActionSupport.buildEvent(profileRequestContext, SAMLEventIds.ENDPOINT_RESOLUTION_FAILED);
             return;
         }
@@ -531,5 +536,5 @@
             return new EndpointCriterion(endpoint, skipValidationSinceSigned);
         }
     }
-
+    
 }



More information about the commits mailing list