[java-identity-provider COMMIT] in /trunk: idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/reso...

[noreply at shibboleth.net]

Author: rdw
Date: Sun Jul 10 09:14:37 2016
New Revision: 8292

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=8292&view=rev
Log:
IDP-1004 Add @Duration to appropriate methods

https://issues.shibboleth.net/jira/browse/IDP-1004

Add @Duration to all appropriate setters as well as their associated
getters.  Leave the @Duration on the setter parameter for readability.


Modified:
    trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractDataConnector.java
    trunk/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/DataConnectorFactoryBean.java
    trunk/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/StoredIDDataConnectorParser.java
    trunk/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/ldap/impl/LDAPDataConnectorParser.java
    trunk/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/rdbms/impl/RDBMSDataConnectorParser.java
    trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AuthenticationFlowDescriptor.java
    trunk/idp-cas-impl/src/main/java/net/shibboleth/idp/cas/config/impl/AbstractProtocolConfiguration.java
    trunk/idp-consent-impl/src/main/java/net/shibboleth/idp/consent/flow/impl/ConsentFlowDescriptor.java
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/interceptor/AbstractProfileInterceptorResult.java
    trunk/idp-saml-api/src/main/java/net/shibboleth/idp/saml/profile/config/AbstractSAMLProfileConfiguration.java
    trunk/idp-saml-api/src/main/java/net/shibboleth/idp/saml/saml2/profile/config/BrowserSSOProfileConfiguration.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/attribute/resolver/impl/StoredIDDataConnector.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/nameid/impl/CryptoTransientIdGenerationStrategy.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/nameid/impl/JDBCPersistentIdStore.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/nameid/impl/JDBCPersistentIdStoreEx.java
    trunk/idp-session-api/src/main/java/net/shibboleth/idp/session/AbstractIdPSession.java
    trunk/idp-session-api/src/main/java/net/shibboleth/idp/session/AbstractSPSessionSerializer.java
    trunk/idp-session-api/src/main/java/net/shibboleth/idp/session/BasicSPSession.java
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/BasicSPSessionSerializer.java
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedIdPSession.java
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java

Modified: trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractDataConnector.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractDataConnector.java?rev=8292&r1=8291&r2=8292&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractDataConnector.java	(original)
+++ trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/AbstractDataConnector.java	Sun Jul 10 09:14:37 2016
@@ -85,7 +85,7 @@
      *
      * @param time what to set
      */
-    public void setLastFail(long time) {
+    public void setLastFail(final long time) {
         lastFail = time;
     }
 
@@ -101,12 +101,12 @@
      *
      * @param delay what to set
      */
-    public void setNoRetryDelay(@Duration long delay) {
+    @Duration public void setNoRetryDelay(@Duration final long delay) {
         noRetryDelay = delay;
     }
 
     /** {@inheritDoc} */
-    @Override public long getNoRetryDelay() {
+    @Override @Duration public long getNoRetryDelay() {
         return noRetryDelay;
     }
 
@@ -127,7 +127,7 @@
         } catch (NoResultAnErrorResolutionException | MultipleResultAnErrorResolutionException e) {
             // Do not record these failures, they are 'expected'
             throw e;
-        } catch (Exception e) {
+        } catch (final Exception e) {
             setLastFail(System.currentTimeMillis());
             throw e;
         }
@@ -138,8 +138,8 @@
         } else {
             log.debug("{} produced the following {} attributes during resolution {}", new Object[] {getLogPrefix(),
                     result.size(), result.keySet(),});
-            for (String attrName : result.keySet()) {
-                IdPAttribute attr = result.get(attrName);
+            for (final String attrName : result.keySet()) {
+                final IdPAttribute attr = result.get(attrName);
                 log.debug("{} Attribute '{}': Values '{}'", new Object[] {getLogPrefix(), attrName, attr.getValues(),});
             }
         }


[... 987 lines stripped ...]