[java-opensaml COMMIT] in /trunk/opensaml-saml-impl/src: main/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionSta...

noreply at shibboleth.net noreply at shibboleth.net
Fri Jan 15 14:35:21 EST 2016


Author: putmanb
Date: Fri Jan 15 14:35:20 2016
New Revision: 4423

URL: http://svn.shibboleth.net/view/java-opensaml?rev=4423&view=rev
Log:
Port of XMLObject part of JOST-242.  Don't trim AuthzDecisionStatement resource values.

Modified:
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionStatementImpl.java
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionStatementTest.java

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionStatementImpl.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionStatementImpl.java?rev=4423&r1=4422&r2=4423&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionStatementImpl.java	(original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionStatementImpl.java	Fri Jan 15 14:35:20 2016
@@ -69,7 +69,7 @@
 
     /** {@inheritDoc} */
     public void setResource(String newResourceURI) {
-        this.resource = prepareForAssignment(this.resource, newResourceURI);
+        this.resource = prepareForAssignment(this.resource, newResourceURI, false);
     }
 
     /** {@inheritDoc} */

Modified: trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionStatementTest.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionStatementTest.java?rev=4423&r1=4422&r2=4423&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionStatementTest.java	(original)
+++ trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/core/impl/AuthzDecisionStatementTest.java	Fri Jan 15 14:35:20 2016
@@ -17,9 +17,6 @@
 
 package org.opensaml.saml.saml2.core.impl;
 
-import org.testng.annotations.Test;
-import org.testng.annotations.BeforeMethod;
-import org.testng.Assert;
 import javax.xml.namespace.QName;
 
 import org.opensaml.core.xml.XMLObjectProviderBaseTestCase;
@@ -28,6 +25,9 @@
 import org.opensaml.saml.saml2.core.AuthzDecisionStatement;
 import org.opensaml.saml.saml2.core.DecisionTypeEnumeration;
 import org.opensaml.saml.saml2.core.Evidence;
+import org.testng.Assert;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
 
 /**
  * Test case for creating, marshalling, and unmarshalling
@@ -124,4 +124,19 @@
         
         assertXMLEquals(expectedChildElementsDOM, authzDecisionStatement);
     }
+    
+    public void testResource() {
+        AuthzDecisionStatement authzDecisionStatement = (AuthzDecisionStatement) buildXMLObject(AuthzDecisionStatement.DEFAULT_ELEMENT_NAME);
+        
+        authzDecisionStatement.setResource("urn:test:foo");
+        Assert.assertEquals(authzDecisionStatement.getResource(), "urn:test:foo");
+        
+        authzDecisionStatement.setResource("");
+        Assert.assertEquals(authzDecisionStatement.getResource(), "");
+        
+        // 3 spaces
+        authzDecisionStatement.setResource("   ");
+        Assert.assertEquals(authzDecisionStatement.getResource(), "   ");
+    }
+    
 }



More information about the commits mailing list