[java-identity-provider COMMIT] /trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractValidationAction....

[noreply at shibboleth.net]

Author: scantor
Date: Tue Feb 23 10:23:10 2016
New Revision: 8103

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=8103&view=rev
Log:
IDP-927 - Race condition between setting of propeties in AbstractValidationAction

https://issues.shibboleth.net/jira/browse/IDP-927

The original reason for trying to fix this up in code was corrected in the bean wiring.

Modified:
    trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractValidationAction.java

Modified: trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractValidationAction.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractValidationAction.java?rev=8103&r1=8102&r2=8103&view=diff
==============================================================================
--- trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractValidationAction.java	(original)
+++ trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractValidationAction.java	Tue Feb 23 10:23:10 2016
@@ -225,10 +225,7 @@
         authenticatedSubject.getPrincipals().clear();
         
         if (principals != null && !principals.isEmpty()) {
-            addDefaultPrincipals = false;
             authenticatedSubject.getPrincipals().addAll(Collections2.filter(principals, Predicates.notNull()));
-        } else {
-            addDefaultPrincipals = true;
         }
     }