[spring-extensions] branch master updated: JSE-16 - HTTPResource contains an unsettable CredentialsProvider ref

Scott Cantor cantor.2 at osu.edu
Thu Dec 29 14:35:07 EST 2016


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository spring-extensions.

View the commit online:
http://git.shibboleth.net/view/?p=spring-extensions.git;a=commit;h=798007e10f3dc4f88c8c680f3ed58ae3040ec59b

The following commit(s) were added to refs/heads/master by this push:
       new  798007e   JSE-16 - HTTPResource contains an unsettable CredentialsProvider ref
798007e is described below

commit 798007e10f3dc4f88c8c680f3ed58ae3040ec59b
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Dec 29 14:35:06 2016 -0500

    JSE-16 - HTTPResource contains an unsettable CredentialsProvider ref
    
    https://issues.shibboleth.net/jira/browse/JSE-16
---
 .../java/net/shibboleth/ext/spring/resource/HTTPResource.java  | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java b/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
index 9c654fa..c9e112f 100644
--- a/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
+++ b/src/main/java/net/shibboleth/ext/spring/resource/HTTPResource.java
@@ -45,7 +45,6 @@ import org.apache.http.client.methods.CloseableHttpResponse;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.client.methods.HttpUriRequest;
 import org.apache.http.client.utils.DateUtils;
-import org.apache.http.impl.client.BasicCredentialsProvider;
 import org.apache.http.util.EntityUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -70,9 +69,6 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
     /** URL to the Resource. */
     @Nonnull private final URL resourceURL;
 
-    /** HttpClient credentials provider. */
-    private BasicCredentialsProvider credentialsProvider;
-
     /**
      * Constructor.
      * 
@@ -109,11 +105,7 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
      * @return a new instance of {@link HttpCacheContext}
      */
     protected HttpCacheContext buildHttpClientContext() {
-        final HttpCacheContext context = HttpCacheContext.create();
-        if (credentialsProvider != null) {
-            context.setCredentialsProvider(credentialsProvider);
-        }
-        return context;
+        return HttpCacheContext.create();
     }
 
     /**

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list