[java-opensaml COMMIT] in /trunk: opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBase64BinaryTest.java op...

[noreply at shibboleth.net]

Author: scantor
Date: Mon Apr  4 23:27:26 2016
New Revision: 4449

URL: http://svn.shibboleth.net/view/java-opensaml?rev=4449&view=rev
Log:
IDP-504 - Unit tests should avoid creating XMLObjectBuilders explicitly

https://issues.shibboleth.net/jira/browse/IDP-504

Modified:
    trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBase64BinaryTest.java
    trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBooleanTest.java
    trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSDateTimeTest.java
    trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSIntegerTest.java
    trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSQNameTest.java
    trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSStringTest.java
    trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSURITest.java
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/RoundTripTest.java
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/ext/saml1md/impl/SourceIDTest.java
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/metadata/resolver/filter/impl/ScriptedFunctionTest.java
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml1/core/impl/AttributeTest.java
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml1/core/impl/SubjectConfirmationTest.java
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/core/SignedAssertionTest.java
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/metadata/impl/IDPSSODescriptorTest.java
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/metadata/impl/SingleLogoutServiceTest.java

Modified: trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBase64BinaryTest.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBase64BinaryTest.java?rev=4449&r1=4448&r2=4449&view=diff
==============================================================================
--- trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBase64BinaryTest.java	(original)
+++ trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBase64BinaryTest.java	Mon Apr  4 23:27:26 2016
@@ -25,12 +25,12 @@
 import net.shibboleth.utilities.java.support.xml.XMLParserException;
 
 import org.opensaml.core.xml.XMLObjectBaseTestCase;
+import org.opensaml.core.xml.XMLObjectBuilder;
 import org.opensaml.core.xml.io.Marshaller;
 import org.opensaml.core.xml.io.MarshallingException;
 import org.opensaml.core.xml.io.Unmarshaller;
 import org.opensaml.core.xml.io.UnmarshallingException;
 import org.opensaml.core.xml.schema.XSBase64Binary;
-import org.opensaml.core.xml.schema.impl.XSBase64BinaryBuilder;
 import org.w3c.dom.Document;
 
 /**
@@ -56,7 +56,7 @@
      */
     @Test
     public void testMarshall() throws MarshallingException, XMLParserException{
-        XSBase64BinaryBuilder xsb64bBuilder = (XSBase64BinaryBuilder) builderFactory.getBuilder(XSBase64Binary.TYPE_NAME);
+        XMLObjectBuilder<XSBase64Binary> xsb64bBuilder = builderFactory.getBuilderOrThrow(XSBase64Binary.TYPE_NAME);
         XSBase64Binary xsb64b = xsb64bBuilder.buildObject(expectedXMLObjectQName, XSBase64Binary.TYPE_NAME);
         xsb64b.setValue(expectedValue);
         

Modified: trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBooleanTest.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBooleanTest.java?rev=4449&r1=4448&r2=4449&view=diff
==============================================================================
--- trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBooleanTest.java	(original)
+++ trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSBooleanTest.java	Mon Apr  4 23:27:26 2016
@@ -25,11 +25,11 @@
 import net.shibboleth.utilities.java.support.xml.XMLParserException;
 
 import org.opensaml.core.xml.XMLObjectBaseTestCase;
+import org.opensaml.core.xml.XMLObjectBuilder;
 import org.opensaml.core.xml.io.Marshaller;
 import org.opensaml.core.xml.io.MarshallingException;
 import org.opensaml.core.xml.io.Unmarshaller;
 import org.opensaml.core.xml.io.UnmarshallingException;
-import org.opensaml.core.xml.schema.impl.XSBooleanBuilder;
 import org.w3c.dom.Document;
 
 /**
@@ -55,7 +55,7 @@
      */
     @Test
     public void testMarshall() throws MarshallingException, XMLParserException{
-        XSBooleanBuilder xsbBuilder = (XSBooleanBuilder) builderFactory.getBuilder(XSBoolean.TYPE_NAME);
+        XMLObjectBuilder<XSBoolean> xsbBuilder = builderFactory.getBuilderOrThrow(XSBoolean.TYPE_NAME);
         XSBoolean xsBoolean = xsbBuilder.buildObject(expectedXMLObjectQName, XSBoolean.TYPE_NAME);
         xsBoolean.setValue(XSBooleanValue.valueOf(expectedValue));
         

Modified: trunk/opensaml-core/src/test/java/org/opensaml/core/xml/schema/XSDateTimeTest.java

[... 460 lines stripped ...]