[java-identity-provider COMMIT] in /trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filt...

[noreply at shibboleth.net]

Author: tzeller
Date: Fri Sep 25 11:24:31 2015
New Revision: 7779

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=7779&view=rev
Log:
Nits : added 'final' keywords, typos.

Modified:
    trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/basic/impl/ScriptedMatcherParser.java
    trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/impl/AbstractWarningFilterParser.java

Modified: trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/basic/impl/ScriptedMatcherParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/basic/impl/ScriptedMatcherParser.java?rev=7779&r1=7778&r2=7779&view=diff
==============================================================================
--- trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/basic/impl/ScriptedMatcherParser.java	(original)
+++ trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/basic/impl/ScriptedMatcherParser.java	Fri Sep 25 11:24:31 2015
@@ -124,7 +124,7 @@
             throw new BeanCreationException("No script specified for this attribute definition");
         }
 
-        String customRef = StringSupport.trimOrNull(config.getAttributeNS(null, "customObjectRef"));
+        final String customRef = StringSupport.trimOrNull(config.getAttributeNS(null, "customObjectRef"));
         if (null != customRef) {
             builder.addPropertyReference("customObject", customRef);
         }

Modified: trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/impl/AbstractWarningFilterParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/impl/AbstractWarningFilterParser.java?rev=7779&r1=7778&r2=7779&view=diff
==============================================================================
--- trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/impl/AbstractWarningFilterParser.java	(original)
+++ trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/impl/AbstractWarningFilterParser.java	Fri Sep 25 11:24:31 2015
@@ -34,7 +34,7 @@
 /**
  * A special case version of {@link BaseFilterParser} which warns if the non legacy name is used.
  * 
- * Initially it will warn once per namesspace.
+ * Initially it will warn once per namespace.
  */
 public abstract class AbstractWarningFilterParser extends BaseFilterParser {
 
@@ -44,7 +44,7 @@
     private static boolean warnedSAML;
 
     /**
-     * Whether we have ever warned because of basic:  content.
+     * Whether we have ever warned because of basic: content.
      */
     private static boolean warnedBasic;
 
@@ -52,26 +52,26 @@
     private final Logger log = LoggerFactory.getLogger(AbstractWarningFilterParser.class);
 
     /** {@inheritDoc} */
-    @Override protected void doParse(@Nonnull Element element, @Nonnull ParserContext parserContext,
-            @Nonnull BeanDefinitionBuilder builder) {
+    @Override protected void doParse(@Nonnull final Element element, @Nonnull final ParserContext parserContext,
+            @Nonnull final BeanDefinitionBuilder builder) {
 
-        QName suppliedQname = DOMTypeSupport.getXSIType(element);
+        final QName suppliedQname = DOMTypeSupport.getXSIType(element);
         if (AttributeFilterSAMLNamespaceHandler.NAMESPACE.equals(suppliedQname.getNamespaceURI())) {
             if (!warnedSAML) {
                 warnedSAML = true;
                 log.warn("Configuration contains at least one element in the deprecated '{}' namespace.",
                         AttributeFilterSAMLNamespaceHandler.NAMESPACE);
             }
-            log.debug("saml: Namespace element {} in {}, consider using {} ", suppliedQname.toString(), parserContext
-                    .getReaderContext().getResource().getDescription(), getAFPName().toString());
+            log.debug("saml: Namespace element {} in {}, consider using {}", suppliedQname.toString(),
+                    parserContext.getReaderContext().getResource().getDescription(), getAFPName().toString());
         } else if (AttributeFilterBasicNamespaceHandler.NAMESPACE.equals(suppliedQname.getNamespaceURI())) {
             if (!warnedBasic) {
                 warnedBasic = true;
                 log.warn("Configuration contains at least one element in the deprecated '{}' namespace.",
                         AttributeFilterBasicNamespaceHandler.NAMESPACE);
             }
-            log.debug("basic: Namespace element {} in {}, consider using {} ", suppliedQname.toString(), parserContext
-                    .getReaderContext().getResource().getDescription(), getAFPName().toString());
+            log.debug("basic: Namespace element {} in {}, consider using {}", suppliedQname.toString(),

[... 13 lines stripped ...]