[java-identity-provider COMMIT] in /trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegatio...

[noreply at shibboleth.net]

Author: putmanb
Date: Tue Oct 20 20:49:53 2015
New Revision: 7841

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=7841&view=rev
Log:
Fix XMLObject cloning, should release self DOM as well as children.

Modified:
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegation/impl/AddAuthnStatementToAssertionFromInboundAssertionToken.java
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegation/impl/AddDelegationRestrictionToAssertions.java

Modified: trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegation/impl/AddAuthnStatementToAssertionFromInboundAssertionToken.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegation/impl/AddAuthnStatementToAssertionFromInboundAssertionToken.java?rev=7841&r1=7840&r2=7841&view=diff
==============================================================================
--- trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegation/impl/AddAuthnStatementToAssertionFromInboundAssertionToken.java	(original)
+++ trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegation/impl/AddAuthnStatementToAssertionFromInboundAssertionToken.java	Tue Oct 20 20:49:53 2015
@@ -260,6 +260,7 @@
     @Nullable protected AuthnStatement getNewAuthnStatement() {
         try {
             AuthnStatement statement = XMLObjectSupport.cloneXMLObject(sourceStatement);
+            statement.releaseDOM();
             statement.releaseChildrenDOM(true);
             return statement;
         } catch (MarshallingException | UnmarshallingException e) {

Modified: trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegation/impl/AddDelegationRestrictionToAssertions.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegation/impl/AddDelegationRestrictionToAssertions.java?rev=7841&r1=7840&r2=7841&view=diff
==============================================================================
--- trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegation/impl/AddDelegationRestrictionToAssertions.java	(original)
+++ trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/saml2/profile/delegation/impl/AddDelegationRestrictionToAssertions.java	Tue Oct 20 20:49:53 2015
@@ -225,6 +225,7 @@
         if (drt != null) {
             try {
                 drt = XMLObjectSupport.cloneXMLObject(drt);
+                drt.releaseDOM();
                 drt.releaseChildrenDOM(true);
             } catch (MarshallingException | UnmarshallingException e) {
                 log.error("{} Error cloning DelegationRestriction Condition", getLogPrefix(), e);