[java-identity-provider COMMIT] /trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/nameid/impl/JDBCPersistent...

[noreply at shibboleth.net]

Author: scantor
Date: Tue Oct 13 16:03:19 2015
New Revision: 7814

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=7814&view=rev
Log:
IDP-829 - Improve logging during verification step.

Modified:
    trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/nameid/impl/JDBCPersistentIdStoreEx.java

Modified: trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/nameid/impl/JDBCPersistentIdStoreEx.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/nameid/impl/JDBCPersistentIdStoreEx.java?rev=7814&r1=7813&r2=7814&view=diff
==============================================================================
--- trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/nameid/impl/JDBCPersistentIdStoreEx.java	(original)
+++ trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/nameid/impl/JDBCPersistentIdStoreEx.java	Tue Oct 13 16:03:19 2015
@@ -751,8 +751,10 @@
             store(newEntry, conn);
             keyMissing = true;
         } catch (final SQLException e) {
-            log.info("{} Duplicate insert failed as required with SQL State '{}' (should be 23505)", getLogPrefix(),
-                    e.getSQLState());
+            if (!retryableErrors.contains(e.getSQLState())) {
+                log.warn("{} Duplicate insert failed as required with SQL State '{}', ensure this value is "
+                        + "configured as a retryable error", getLogPrefix(), e.getSQLState());
+            }
         } finally {
             
         }