[java-opensaml COMMIT] /trunk/opensaml-xmlsec-impl/src/main/java/org/opensaml/xmlsec/signature/support/impl/ExplicitK...

noreply at shibboleth.net noreply at shibboleth.net
Fri Nov 6 19:39:25 EST 2015


Author: putmanb
Date: Fri Nov  6 19:39:25 2015
New Revision: 4402

URL: http://svn.shibboleth.net/view/java-opensaml?rev=4402&view=rev
Log:
OSJ-141: review logging for ExplicitKeySignatureTrustEngine

Modified:
    trunk/opensaml-xmlsec-impl/src/main/java/org/opensaml/xmlsec/signature/support/impl/ExplicitKeySignatureTrustEngine.java

Modified: trunk/opensaml-xmlsec-impl/src/main/java/org/opensaml/xmlsec/signature/support/impl/ExplicitKeySignatureTrustEngine.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-xmlsec-impl/src/main/java/org/opensaml/xmlsec/signature/support/impl/ExplicitKeySignatureTrustEngine.java?rev=4402&r1=4401&r2=4402&view=diff
==============================================================================
--- trunk/opensaml-xmlsec-impl/src/main/java/org/opensaml/xmlsec/signature/support/impl/ExplicitKeySignatureTrustEngine.java	(original)
+++ trunk/opensaml-xmlsec-impl/src/main/java/org/opensaml/xmlsec/signature/support/impl/ExplicitKeySignatureTrustEngine.java	Fri Nov  6 19:39:25 2015
@@ -149,6 +149,7 @@
 
         // First try the optional supplied candidate credential
         if (candidateCredential != null) {
+            log.debug("Attempting to verify raw signature using supplied candidate credential");
             try {
                 if (XMLSigningUtil.verifyWithURI(candidateCredential, algorithmURI, signature, content)) {
                     log.debug("Successfully verified signature using supplied candidate credential");
@@ -162,7 +163,7 @@
                 }
             } catch (SecurityException e) {
                 // Java 7 now throws this exception under conditions such as mismatched key sizes.
-                // Swallow this, it's logged by the verifyWithURI method already.
+                log.debug("Saw fatal error attempting to verify raw signature with supplied candidate credential", e);
             }
         }
 
@@ -179,7 +180,7 @@
                 }
             } catch (SecurityException e) {
                 // Java 7 now throws this exception under conditions such as mismatched key sizes.
-                // Swallow this, it's logged by the verifyWithURI method already.
+                log.debug("Saw fatal error attempting to verify raw signature with trusted credential", e);
             }
         }
         log.debug("Failed to verify signature using either supplied candidate credential"



More information about the commits mailing list