[java-identity-provider COMMIT] in /trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring: factory...

[noreply at shibboleth.net]

Author: rdw
Date: Fri Nov  6 10:38:01 2015
New Revision: 7952

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=7952&view=rev
Log:
IDP-730 Remove some property trimming around passwords

https://issues.shibboleth.net/jira/browse/IDP-730

A final review found 4 places where we were trimming passwords (mostly proxy password for HTTP).  Remove that

Modified:
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/factory/BasicX509CredentialFactoryBean.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/AbstractDynamicHTTPMetadataProviderParser.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/HTTPMetadataProviderParser.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/resource/impl/SVNResourceParser.java

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/factory/BasicX509CredentialFactoryBean.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/factory/BasicX509CredentialFactoryBean.java?rev=7952&r1=7951&r2=7952&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/factory/BasicX509CredentialFactoryBean.java	(original)
+++ trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/factory/BasicX509CredentialFactoryBean.java	Fri Nov  6 10:38:01 2015
@@ -72,7 +72,7 @@
      * @param password password for the private key, may be null if the key is not encrypted
      */
     public void setPrivateKeyPassword(@Nullable final String password) {
-        keyPass = StringSupport.trimOrNull(password);
+        keyPass = password;
     }
     
     /**
@@ -103,7 +103,7 @@
 
             X509Certificate certificate;
             try (final InputStream is = certResource.getInputStream()) {
-                certificate = (X509Certificate) CertUtil.readCertificate(is);
+                certificate = CertUtil.readCertificate(is);
             }
             
             if (keyResource == null) {

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/AbstractDynamicHTTPMetadataProviderParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/AbstractDynamicHTTPMetadataProviderParser.java?rev=7952&r1=7951&r2=7952&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/AbstractDynamicHTTPMetadataProviderParser.java	(original)
+++ trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/AbstractDynamicHTTPMetadataProviderParser.java	Fri Nov  6 10:38:01 2015
@@ -212,8 +212,7 @@
         }
 
         if (element.hasAttributeNS(null, "proxyPassword")) {
-            clientBuilder.addPropertyValue("connectionProxyPassword",
-                    StringSupport.trimOrNull(element.getAttributeNS(null, "proxyPassword")));
+            clientBuilder.addPropertyValue("connectionProxyPassword", element.getAttributeNS(null, "proxyPassword"));
         }
 
         return clientBuilder.getBeanDefinition();

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/HTTPMetadataProviderParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/HTTPMetadataProviderParser.java?rev=7952&r1=7951&r2=7952&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/HTTPMetadataProviderParser.java	(original)
+++ trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/impl/HTTPMetadataProviderParser.java	Fri Nov  6 10:38:01 2015
@@ -221,8 +221,7 @@
         }
 
         if (element.hasAttributeNS(null, "proxyPassword")) {
-            clientBuilder.addPropertyValue("connectionProxyPassword",
-                    StringSupport.trimOrNull(element.getAttributeNS(null, "proxyPassword")));
+            clientBuilder.addPropertyValue("connectionProxyPassword", element.getAttributeNS(null, "proxyPassword"));
         }
 
         return clientBuilder.getBeanDefinition();

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/resource/impl/SVNResourceParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/resource/impl/SVNResourceParser.java?rev=7952&r1=7951&r2=7952&view=diff
==============================================================================

[... 55 lines stripped ...]