[utilities COMMIT] /spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/config/StringBooleanToPredicateCo...

[noreply at shibboleth.net]

Author: scantor
Date: Fri May 29 19:21:09 2015
New Revision: 799

URL: http://svn.shibboleth.net/view/utilities?rev=799&view=rev
Log:
IDP-730 - trim input being converted to a boolean, so "true " evals as true

Modified:
    spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/config/StringBooleanToPredicateConverter.java

Modified: spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/config/StringBooleanToPredicateConverter.java
URL: http://svn.shibboleth.net/view/utilities/spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/config/StringBooleanToPredicateConverter.java?rev=799&r1=798&r2=799&view=diff
==============================================================================
--- spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/config/StringBooleanToPredicateConverter.java	(original)
+++ spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/config/StringBooleanToPredicateConverter.java	Fri May 29 19:21:09 2015
@@ -17,6 +17,8 @@
 
 package net.shibboleth.ext.spring.config;
 
+import net.shibboleth.utilities.java.support.primitive.StringSupport;
+
 import org.springframework.core.convert.converter.Converter;
 
 import com.google.common.base.Predicate;
@@ -29,7 +31,7 @@
 
     /** {@inheritDoc} */
     public Predicate convert(String source) {
-        return Boolean.valueOf(source) ? Predicates.alwaysTrue() : Predicates.alwaysFalse();
+        return Boolean.valueOf(StringSupport.trimOrNull(source)) ? Predicates.alwaysTrue() : Predicates.alwaysFalse();
     }
     
 }