[java-identity-provider COMMIT] /trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java

noreply at shibboleth.net noreply at shibboleth.net
Thu Jun 18 12:36:44 EDT 2015


Author: scantor
Date: Thu Jun 18 12:36:43 2015
New Revision: 7574

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=7574&view=rev
Log:
IDP-744 - ExternalAuthentication.start method can return an empty conversation key

Modified:
    trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java

Modified: trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java?rev=7574&r1=7573&r2=7574&view=diff
==============================================================================
--- trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java	(original)
+++ trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/ExternalAuthentication.java	Thu Jun 18 12:36:43 2015
@@ -80,7 +80,7 @@
     @Nonnull @NotEmpty public static String startExternalAuthentication(@Nonnull final HttpServletRequest request)
             throws ExternalAuthenticationException {
         final String conv = request.getParameter(CONVERSATION_KEY);
-        if (conv == null) {
+        if (conv == null || conv.isEmpty()) {
             throw new ExternalAuthenticationException("No conversation key found in request");
         }
         



More information about the commits mailing list