[js-embedded-discovery COMMIT] /trunk/src/javascript/idpselect.js

noreply at shibboleth.net noreply at shibboleth.net
Fri Jan 23 06:15:44 EST 2015


Author: rdw
Date: Fri Jan 23 06:15:44 2015
New Revision: 136

URL: http://svn.shibboleth.net/view/js-embedded-discovery?rev=136&view=rev
Log:
EDS-26 add labels to the dropdowns to aid screen readers

Modified:
    trunk/src/javascript/idpselect.js

Modified: trunk/src/javascript/idpselect.js
URL: http://svn.shibboleth.net/view/js-embedded-discovery/trunk/src/javascript/idpselect.js?rev=136&r1=135&r2=136&view=diff
==============================================================================
--- trunk/src/javascript/idpselect.js (original)
+++ trunk/src/javascript/idpselect.js Fri Jan 23 06:15:44 2015
@@ -778,14 +778,18 @@
         if (showListFirst) {
             idpEntryDiv.style.display = 'none';
         }
+        
+        var label = document.createElement('label');
+        label.setAttribute('for', idPrefix + 'Input');
 
         if (preferredTile) {
-            buildTextDiv(idpEntryDiv, 'idpEntry.label');
+            buildTextDiv(label, 'idpEntry.label');
         } else {
-            buildTextDiv(idpEntryDiv, 'idpEntry.NoPreferred.label');
+            buildTextDiv(label, 'idpEntry.NoPreferred.label');
         }
 
         var form = buildSelectForm();
+        form.appendChild(label);
       
         var textInput = document.createElement('input');
         form.appendChild(textInput);
@@ -859,10 +863,13 @@
             idpListDiv.style.display = 'none';
         }
 
+        var label = document.createElement('label');
+        label.setAttribute('for', idPrefix + 'Selector');
+
         if (preferredTile) {
-            buildTextDiv(idpListDiv, 'idpList.label');
+            buildTextDiv(label, 'idpList.label');
         } else {
-            buildTextDiv(idpListDiv, 'idpList.NoPreferred.label');
+            buildTextDiv(label, 'idpList.NoPreferred.label');
         }
 
         idpSelect = document.createElement('select');
@@ -883,7 +890,7 @@
         }
 
         var form = buildSelectForm();
-
+        form.appendChild(label);
         form.appendChild(idpSelect);
 
         form.onsubmit = function () {



More information about the commits mailing list