[js-embedded-discovery COMMIT] in /trunk: doc/RELEASE-NOTES.txt src/javascript/idpselect.js

noreply at shibboleth.net noreply at shibboleth.net
Mon Jan 5 06:54:02 EST 2015


Author: rdw
Date: Mon Jan  5 06:54:01 2015
New Revision: 114

URL: http://svn.shibboleth.net/view/js-embedded-discovery?rev=114&view=rev
Log:
EDS-30 Use %20 as the separator for entityIDs in the cookie, but continue to understand '+'

Modified:
    trunk/doc/RELEASE-NOTES.txt
    trunk/src/javascript/idpselect.js

Modified: trunk/doc/RELEASE-NOTES.txt
URL: http://svn.shibboleth.net/view/js-embedded-discovery/trunk/doc/RELEASE-NOTES.txt?rev=114&r1=113&r2=114&view=diff
==============================================================================
--- trunk/doc/RELEASE-NOTES.txt (original)
+++ trunk/doc/RELEASE-NOTES.txt Mon Jan  5 06:54:01 2015
@@ -6,6 +6,7 @@
 EDS-53 Add pr-br messages.
 EDS-42 Move Compressor up to 2.4.8
 EDS-39 Ship non mimimized sources
+EDS-30 Use %20 as the separator for entityIDs in the cookie, but continue to understand '+'
 
 Changed in V1.0.3
 =============================================

Modified: trunk/src/javascript/idpselect.js
URL: http://svn.shibboleth.net/view/js-embedded-discovery/trunk/src/javascript/idpselect.js?rev=114&r1=113&r2=114&view=diff
==============================================================================
--- trunk/src/javascript/idpselect.js (original)
+++ trunk/src/javascript/idpselect.js Mon Jan  5 06:54:01 2015
@@ -1189,7 +1189,9 @@
             var cookieValues = cookie.substring(splitPoint+1);
                                 
             if ( '_saml_idp' == cookieName.replace(/^\s+|\s+$/g, '') ) {
-                cookieValues = cookieValues.replace(/^\s+|\s+$/g, '').split('+');
+                cookieValues = cookieValues.replace(/^\s+|\s+$/g, '');
+                cookieValues = cookieValues.replace('+','%20');
+                cookieValues = cookieValues.split('%20');
                 for(j=0; j< cookieValues.length; j++){
                     if (0 === cookieValues[j].length) {
                         continue;
@@ -1229,8 +1231,9 @@
             expireDate = new Date(now.getTime() + cookieTTL);
         }
         
-        document.cookie='_saml_idp' + '=' + cookieData.join('+') + '; path = /' +
+        document.cookie='_saml_idp' + '=' + cookieData.join('%20') + '; path = /' +
             ((expireDate===null) ? '' : '; expires=' + expireDate.toUTCString());
+        
     };
     
     /**



More information about the commits mailing list