[java-identity-provider COMMIT] in /trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter...
noreply at shibboleth.net
noreply at shibboleth.net
Mon Apr 6 06:38:42 EDT 2015
Author: rdw
Date: Mon Apr 6 06:38:42 2015
New Revision: 7469
URL: http://svn.shibboleth.net/view/java-identity-provider?rev=7469&view=rev
Log:
IDP-682 Test aganst null PRC
Modified:
trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcher.java
trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/policyrule/impl/ScriptedPolicyRule.java
Modified: trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcher.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcher.java?rev=7469&r1=7468&r2=7469&view=diff
==============================================================================
--- trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcher.java (original)
+++ trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcher.java Mon Apr 6 06:38:42 2015
@@ -143,8 +143,11 @@
final EvaluableScript currentScript = script;
final SimpleScriptContext scriptContext = new SimpleScriptContext();
scriptContext.setAttribute("filterContext", filterContext, ScriptContext.ENGINE_SCOPE);
- scriptContext
- .setAttribute("profileContext", prcLookupStrategy.apply(filterContext), ScriptContext.ENGINE_SCOPE);
+ final ProfileRequestContext prc = prcLookupStrategy.apply(filterContext);
+ if (null == prc) {
+ log.error("{} Could not locate ProfileRequestContext", getLogPrefix());
+ }
+ scriptContext.setAttribute("profileContext", prc, ScriptContext.ENGINE_SCOPE);
scriptContext.setAttribute("attribute", attribute, ScriptContext.ENGINE_SCOPE);
try {
Modified: trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/policyrule/impl/ScriptedPolicyRule.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/policyrule/impl/ScriptedPolicyRule.java?rev=7469&r1=7468&r2=7469&view=diff
==============================================================================
--- trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/policyrule/impl/ScriptedPolicyRule.java (original)
+++ trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/policyrule/impl/ScriptedPolicyRule.java Mon Apr 6 06:38:42 2015
@@ -131,8 +131,11 @@
final SimpleScriptContext scriptContext = new SimpleScriptContext();
scriptContext.setAttribute("filterContext", filterContext, ScriptContext.ENGINE_SCOPE);
- scriptContext
- .setAttribute("profileContext", prcLookupStrategy.apply(filterContext), ScriptContext.ENGINE_SCOPE);
+ final ProfileRequestContext prc = prcLookupStrategy.apply(filterContext);
+ if (null == prc) {
+ log.error("{} Could not locate ProfileRequestContext", getLogPrefix());
+ }
+ scriptContext.setAttribute("profileContext", prc, ScriptContext.ENGINE_SCOPE);
try {
final Object result = currentScript.eval(scriptContext);
More information about the commits
mailing list