[java-opensaml COMMIT] in /trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml: common/profile/logic/DefaultLoca...

[noreply at shibboleth.net]

Author: scantor
Date: Fri Sep 19 23:26:24 2014
New Revision: 4028

URL: http://svn.shibboleth.net/view/java-opensaml?rev=4028&view=rev
Log:
Fix warnings.

Modified:
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/profile/logic/DefaultLocalErrorPredicate.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/filter/impl/EntityRoleFilter.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/metadata/impl/AffiliateMemberImpl.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/metadata/impl/AffiliationDescriptorImpl.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/metadata/impl/ContactPersonImpl.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/metadata/impl/EmailAddressImpl.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/metadata/impl/OrganizationImpl.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/metadata/impl/RoleDescriptorImpl.java

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/profile/logic/DefaultLocalErrorPredicate.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/profile/logic/DefaultLocalErrorPredicate.java?rev=4028&r1=4027&r2=4028&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/profile/logic/DefaultLocalErrorPredicate.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/profile/logic/DefaultLocalErrorPredicate.java Fri Sep 19 23:26:24 2014
@@ -126,7 +126,7 @@
      * 
      * @param events locally handled events
      */
-    public void setLocalEvents(@Nonnull @NonnullElements Collection<String> events) {
+    public void setLocalEvents(@Nonnull @NonnullElements final Collection<String> events) {
         if (events == null) {
             localEvents = Collections.emptySet();
         } else {

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/filter/impl/EntityRoleFilter.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/filter/impl/EntityRoleFilter.java?rev=4028&r1=4027&r2=4028&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/filter/impl/EntityRoleFilter.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/filter/impl/EntityRoleFilter.java Fri Sep 19 23:26:24 2014
@@ -35,7 +35,7 @@
 import org.slf4j.LoggerFactory;
 
 /**
- * A filter the removes roles, from an entity descriptor. For those roles specified within the SAML metadata
+ * A filter that removes roles from an entity descriptor. For those roles specified within the SAML metadata
  * specification the role element QName is used to identify the role. For other roles, those that appear as
  * &lt;RoleDescriptor xsi:type="someRoleType"&gt; the role schema type is used to identify the role.
  * 
@@ -131,6 +131,7 @@
     }
 
     /** {@inheritDoc} */
+    @Override
     public XMLObject filter(XMLObject metadata) throws FilterException {
         if (metadata == null) {
             return null;
@@ -145,8 +146,9 @@
         return metadata;
     }
 
-    /**
-     * Filters entities descriptor.
+// Checkstyle: CyclomaticComplexity OFF    
+    /**
+     * Filters {@link EntitiesDescriptor}.
      * 
      * @param descriptor entities descriptor to filter
      * 
@@ -199,6 +201,7 @@
             entitiesDescriptors.removeAll(emptyEntitiesDescriptors);
         }
     }
+// Checkstyle: CyclomaticComplexity ON
 
     /**
      * Filters entity descriptor roles.

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/metadata/impl/AffiliateMemberImpl.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/metadata/impl/AffiliateMemberImpl.java?rev=4028&r1=4027&r2=4028&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/metadata/impl/AffiliateMemberImpl.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/metadata/impl/AffiliateMemberImpl.java Fri Sep 19 23:26:24 2014
@@ -43,12 +43,14 @@
     }
 
     /** {@inheritDoc} */
+    @Override
     public String getID() {
         return id;
     }
 
     /** {@inheritDoc} */
-    public void setID(String newID) throws IllegalArgumentException {
+    @Override
+    public void setID(String newID) {
         if (newID != null && newID.length() > 1024) {
             throw new IllegalArgumentException("Member ID can not exceed 1024 characters in length");
         }
@@ -57,6 +59,7 @@
     }
 
     /** {@inheritDoc} */
+    @Override
     public List<XMLObject> getOrderedChildren() {
         // No children
         return null;


[... 514 lines stripped ...]