[java-identity-provider COMMIT] /trunk/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resol...

noreply at shibboleth.net noreply at shibboleth.net
Mon Oct 20 04:07:23 EDT 2014


Author: rdw
Date: Mon Oct 20 04:07:21 2014
New Revision: 6748

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=6748&view=rev
Log:
Case IdP-378  Warn if the TransientConnectorParser has "noResultIsError" set

Modified:
    trunk/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/pc/TransientConnectorParser.java

Modified: trunk/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/pc/TransientConnectorParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/pc/TransientConnectorParser.java?rev=6748&r1=6747&r2=6748&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/pc/TransientConnectorParser.java (original)
+++ trunk/idp-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/pc/TransientConnectorParser.java Mon Oct 20 04:07:21 2014
@@ -24,6 +24,8 @@
 import net.shibboleth.idp.saml.nameid.impl.TransientNameIdentifierDecoder;
 import net.shibboleth.utilities.java.support.primitive.StringSupport;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.support.BeanDefinitionBuilder;
 import org.springframework.beans.factory.xml.ParserContext;
 import org.w3c.dom.Element;
@@ -36,6 +38,9 @@
 
     /** Schema type name. */
     public static final QName ELEMENT_NAME = new QName(PrincipalConnectorNamespaceHandler.NAMESPACE, "Transient");
+
+    /** Class logger. */
+    private final Logger log = LoggerFactory.getLogger(TransientConnectorParser.class);
 
     /** {@inheritDoc} */
     @Override protected void addSAMLDecoders(@Nonnull Element config, @Nonnull ParserContext parserContext,
@@ -57,6 +62,10 @@
                 
         builder.addConstructorArgValue(subBuilder.getBeanDefinition());
         
+        if (config.hasAttributeNS(null, "noResultIsError")) {
+            log.warn("Transient Principal Connector does not support 'noResultIsError'");
+        }
+        
         // NameIdentifier
         subBuilder = BeanDefinitionBuilder.genericBeanDefinition(TransientNameIdentifierDecoder.class);
         subBuilder.setInitMethodName("initialize");



More information about the commits mailing list