[java-identity-provider COMMIT] in /trunk: idp-consent/src/main/java/net/shibboleth/idp/consent/flow/storage/UpdateSt...

[noreply at shibboleth.net]

Author: tzeller
Date: Thu Nov 20 23:55:48 2014
New Revision: 6982

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=6982&view=rev
Log:
Checkpoint consent cleanup and tests.

Added:
    trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/storage/StorageIndexTest.java   (with props)
    trunk/idp-profile-api/src/test/java/net/shibboleth/idp/profile/interceptor/AbstractProfileInterceptorResultTest.java   (with props)
Modified:
    trunk/idp-consent/src/main/java/net/shibboleth/idp/consent/flow/storage/UpdateStorageIndex.java
    trunk/idp-consent/src/main/java/net/shibboleth/idp/consent/storage/StorageIndex.java
    trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/ConsentTest.java
    trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/flow/ar/ReleaseAttributesTest.java
    trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/interceptor/AbstractProfileInterceptorResult.java

Modified: trunk/idp-consent/src/main/java/net/shibboleth/idp/consent/flow/storage/UpdateStorageIndex.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-consent/src/main/java/net/shibboleth/idp/consent/flow/storage/UpdateStorageIndex.java?rev=6982&r1=6981&r2=6982&view=diff
==============================================================================
--- trunk/idp-consent/src/main/java/net/shibboleth/idp/consent/flow/storage/UpdateStorageIndex.java (original)
+++ trunk/idp-consent/src/main/java/net/shibboleth/idp/consent/flow/storage/UpdateStorageIndex.java Thu Nov 20 23:55:48 2014
@@ -123,7 +123,6 @@
                 interceptorContext.getResults().add(result);
                 log.debug("{} Consent index has changed, adding result '{}' to interceptor context", getLogPrefix(),
                         result);
-                // TODO expiration ?
             } else {
                 log.debug("{} Consent index has not changed, nothing to do", getLogPrefix());
             }

Modified: trunk/idp-consent/src/main/java/net/shibboleth/idp/consent/storage/StorageIndex.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-consent/src/main/java/net/shibboleth/idp/consent/storage/StorageIndex.java?rev=6982&r1=6981&r2=6982&view=diff
==============================================================================
--- trunk/idp-consent/src/main/java/net/shibboleth/idp/consent/storage/StorageIndex.java (original)
+++ trunk/idp-consent/src/main/java/net/shibboleth/idp/consent/storage/StorageIndex.java Thu Nov 20 23:55:48 2014
@@ -37,7 +37,6 @@
 /**
  * Holds a storage context and associated keys to serve as a secondary index for lookup of records from storage.
  */
-// TODO tests
 public class StorageIndex {
 
     /** Storage context. */

Modified: trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/ConsentTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/ConsentTest.java?rev=6982&r1=6981&r2=6982&view=diff
==============================================================================
--- trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/ConsentTest.java (original)
+++ trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/ConsentTest.java Thu Nov 20 23:55:48 2014
@@ -61,6 +61,9 @@
     }
 
     @Test public void testEqualityAndHashCode() {
+        Assert.assertEquals(consent, consent);
+        Assert.assertNotEquals(consent, null);
+        
         final Consent otherConsent = new Consent();
         Assert.assertNotEquals(consent, otherConsent);
         Assert.assertFalse(consent.hashCode() == otherConsent.hashCode());

Modified: trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/flow/ar/ReleaseAttributesTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/flow/ar/ReleaseAttributesTest.java?rev=6982&r1=6981&r2=6982&view=diff
==============================================================================
--- trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/flow/ar/ReleaseAttributesTest.java (original)
+++ trunk/idp-consent/src/test/java/net/shibboleth/idp/consent/flow/ar/ReleaseAttributesTest.java Thu Nov 20 23:55:48 2014
@@ -35,7 +35,6 @@
 import org.testng.annotations.Test;
 
 /** {@link ReleaseAttributes} unit test. */
-// TODO incomplete
 public class ReleaseAttributesTest extends AbstractAttributeReleaseActionTest {
 
     private AttributeReleaseContext arc;

Modified: trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/interceptor/AbstractProfileInterceptorResult.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/interceptor/AbstractProfileInterceptorResult.java?rev=6982&r1=6981&r2=6982&view=diff
==============================================================================
--- trunk/idp-profile-api/src/main/java/net/shibboleth/idp/profile/interceptor/AbstractProfileInterceptorResult.java (original)

[... 10 lines stripped ...]