[java-identity-provider COMMIT] in /trunk: idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/fil...

[noreply at shibboleth.net]

Author: rdw
Date: Sun Nov 16 07:05:45 2014
New Revision: 6916

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=6916&view=rev
Log:
Cleanup.  Todos are either done or their time has passed

Modified:
    trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/saml/MappedAttributeInMetadataRuleParser.java
    trunk/idp-attribute-resolver-impl/src/test/java/net/shibboleth/idp/attribute/resolver/impl/AttributeResolverImplTest.java
    trunk/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/AttributeResolverTest.java

Modified: trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/saml/MappedAttributeInMetadataRuleParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/saml/MappedAttributeInMetadataRuleParser.java?rev=6916&r1=6915&r2=6916&view=diff
==============================================================================
--- trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/saml/MappedAttributeInMetadataRuleParser.java (original)
+++ trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/saml/MappedAttributeInMetadataRuleParser.java Sun Nov 16 07:05:45 2014
@@ -17,7 +17,6 @@
 
 package net.shibboleth.idp.attribute.filter.spring.saml;
 
-// TODO TEST
 import javax.annotation.Nonnull;
 import javax.xml.namespace.QName;
 

Modified: trunk/idp-attribute-resolver-impl/src/test/java/net/shibboleth/idp/attribute/resolver/impl/AttributeResolverImplTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-impl/src/test/java/net/shibboleth/idp/attribute/resolver/impl/AttributeResolverImplTest.java?rev=6916&r1=6915&r2=6916&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-impl/src/test/java/net/shibboleth/idp/attribute/resolver/impl/AttributeResolverImplTest.java (original)
+++ trunk/idp-attribute-resolver-impl/src/test/java/net/shibboleth/idp/attribute/resolver/impl/AttributeResolverImplTest.java Sun Nov 16 07:05:45 2014
@@ -49,8 +49,6 @@
 
 import com.google.common.collect.Sets;
 
-//TODO test during resolve: failover, requested attributes, bad pluginIDs, plugin throwing error, error propagation
-
 /** Test case for {@link AttributeResolverImpl}. */
 public class AttributeResolverImplTest {
     private final Logger log = LoggerFactory.getLogger(AttributeResolverImplTest.class);

Modified: trunk/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/AttributeResolverTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/AttributeResolverTest.java?rev=6916&r1=6915&r2=6916&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/AttributeResolverTest.java (original)
+++ trunk/idp-attribute-resolver-spring/src/test/java/net/shibboleth/idp/attribute/resolver/spring/AttributeResolverTest.java Sun Nov 16 07:05:45 2014
@@ -195,7 +195,6 @@
         values = attribute.getValues();
         Assert.assertEquals(values.size(), 1);
 
-        // RDBMS TODO wire in the template
         attribute = resolvedAttributes.get("pagerNumber");
         Assert.assertNotNull(attribute);
         values = attribute.getValues();