[java-opensaml COMMIT] in /trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml: saml1/profile/impl/AddStatusToRe...

[noreply at shibboleth.net]

Author: scantor
Date: Thu Jun  5 11:58:35 2014
New Revision: 3915

URL: http://svn.shibboleth.net/view/java-opensaml?rev=3915&view=rev
Log:
More doc fixes, remove synchronized from setters.

Modified:
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/profile/impl/AddStatusToResponse.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/AddStatusToResponse.java

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/profile/impl/AddStatusToResponse.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/profile/impl/AddStatusToResponse.java?rev=3915&r1=3914&r2=3915&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/profile/impl/AddStatusToResponse.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml1/profile/impl/AddStatusToResponse.java Thu Jun  5 11:58:35 2014
@@ -113,7 +113,7 @@
      * 
      * @param condition predicate for detailed errors condition
      */
-    public synchronized void setDetailedErrorsCondition(@Nonnull final Predicate<ProfileRequestContext> condition) {
+    public void setDetailedErrorsCondition(@Nonnull final Predicate<ProfileRequestContext> condition) {
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
 
         detailedErrorsCondition =
@@ -125,8 +125,7 @@
      * 
      * @param strategy strategy used to obtain status codes
      */
-    public synchronized void setStatusCodesLookupStrategy(
-            @Nullable final Function<ProfileRequestContext,List<QName>> strategy) {
+    public void setStatusCodesLookupStrategy(@Nullable final Function<ProfileRequestContext,List<QName>> strategy) {
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
 
         statusCodesLookupStrategy = strategy;
@@ -137,8 +136,7 @@
      * 
      * @param strategy strategy used to obtain a status message
      */
-    public synchronized void setStatusMessageLookupStrategy(
-            @Nullable final Function<ProfileRequestContext,String> strategy) {
+    public void setStatusMessageLookupStrategy(@Nullable final Function<ProfileRequestContext,String> strategy) {
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
 
         statusMessageLookupStrategy = strategy;
@@ -149,8 +147,7 @@
      * 
      * @param strategy strategy used to locate the {@link Response} to operate on
      */
-    public synchronized void setResponseLookupStrategy(
-            @Nonnull final Function<ProfileRequestContext,Response> strategy) {
+    public void setResponseLookupStrategy(@Nonnull final Function<ProfileRequestContext,Response> strategy) {
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
 
         responseLookupStrategy = Constraint.isNotNull(strategy, "Response lookup strategy cannot be null");
@@ -162,7 +159,7 @@
      * 
      * @param codes list of status code values to insert
      */
-    public synchronized void setStatusCodes(@Nonnull @NonnullElements List<QName> codes) {
+    public void setStatusCodes(@Nonnull @NonnullElements List<QName> codes) {
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
         
         Constraint.isNotNull(codes, "Status code list cannot be null");
@@ -170,15 +167,12 @@
     }
     
     /**
-     * Set a default status message to use.
-     * 
-     * <p>If set, the {@link StatusMessage} element will be set to this value, unless
-     * {@link #statusMessageFromEvent} is true, the event exists and is mappable to a
-     * message, and {@link RelyingPartyConfiguration#isDetailedErrors()} is also true. 
+     * Set a default status message to use in the event that error detail is off,
+     * or no specific message is obtained.
      * 
      * @param message default status message
      */
-    public synchronized void setStatusMessage(@Nullable final String message) {
+    public void setStatusMessage(@Nullable final String message) {
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
         
         statusMessage = StringSupport.trimOrNull(message);

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/AddStatusToResponse.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/AddStatusToResponse.java?rev=3915&r1=3914&r2=3915&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/AddStatusToResponse.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/AddStatusToResponse.java Thu Jun  5 11:58:35 2014
@@ -112,8 +112,7 @@
      * 
      * @param strategy strategy used to locate the {@link Response} to operate on
      */
-    public synchronized void setResponseLookupStrategy(

[... 63 lines stripped ...]