[java-identity-provider COMMIT] in /trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl: StorageBack...

[noreply at shibboleth.net]

Author: scantor
Date: Thu Jul 31 12:13:41 2014
New Revision: 6372

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=6372&view=rev
Log:
Logging fixes.

Modified:
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedIdPSession.java
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/UpdateSessionWithAuthenticationResult.java
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/UpdateSessionWithSPSession.java

Modified: trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedIdPSession.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedIdPSession.java?rev=6372&r1=6371&r2=6372&view=diff
==============================================================================
--- trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedIdPSession.java (original)
+++ trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedIdPSession.java Thu Jul 31 12:13:41 2014
@@ -94,7 +94,7 @@
                     getId(), StorageBackedSessionManager.SESSION_MASTER_KEY, exp);
             super.setLastActivityInstant(instant);
         } catch (final IOException e) {
-            log.error("Exception updating expiration of master record for session " + getId(), e);
+            log.error("Exception updating expiration of master record for session {}", getId(), e);
             if (!sessionManager.isMaskStorageFailure()) {
                 throw new SessionException("Exception updating expiration of session record", e);
             }
@@ -140,7 +140,7 @@
                 log.error("Exhausted retry attempts updating record for session {}", getId());
             }
         } catch (final IOException e) {
-            log.error("Exception updating address binding of master record for session " + getId(), e);
+            log.error("Exception updating address binding of master record for session {}", getId(), e);
             if (!sessionManager.isMaskStorageFailure()) {
                 throw new SessionException("Exception updating address binding of session record", e);
             }
@@ -239,8 +239,8 @@
             }
             return prev;
         } catch (final IOException e) {
-            log.error("Exception saving AuthenticationResult record for session " + getId()
-                    + " and flow " + result.getAuthenticationFlowId(), e);
+            log.error("Exception saving AuthenticationResult record for session {} and flow {}", getId(),
+                    result.getAuthenticationFlowId(), e);
             if (!sessionManager.isMaskStorageFailure()) {
                 throw new SessionException("Exception saving AuthenticationResult record to storage", e);
             }
@@ -262,8 +262,8 @@
                             flowId, getId());
                 }
             } catch (final IOException e) {
-                log.error("Exception updating AuthenticationResult expiration for session " + getId()
-                        + " and flow " + flowId, e);
+                log.error("Exception updating AuthenticationResult expiration for session {} and flow {}", getId(),
+                        flowId, e);
                 if (!sessionManager.isMaskStorageFailure()) {
                     throw new SessionException("Exception updating AuthenticationResult expiration in storage", e);
                 }
@@ -281,8 +281,8 @@
                 // Remove the separate record.
                 sessionManager.getStorageService().delete(getId(), result.getAuthenticationFlowId());
             } catch (final IOException e) {
-                log.error("Exception removing AuthenticationResult record for session " + getId()
-                        + " and flow " + result.getAuthenticationFlowId(), e);
+                log.error("Exception removing AuthenticationResult record for session {} and flow {}", getId(),
+                        result.getAuthenticationFlowId(), e);
                 if (!sessionManager.isMaskStorageFailure()) {
                     throw new SessionException("Exception removing AuthenticationResult record from storage", e);
                 }
@@ -417,8 +417,8 @@
                 sessionManager.indexBySPSession(this, spSession, 10);
                 return prev;
             } catch (final IOException e) {
-                log.error("Exception saving SPSession record for IdP session " + getId()
-                        + " and service " + spSession.getId(), e);
+                log.error("Exception saving SPSession record for IdP session {} and service {}", getId(),
+                        spSession.getId(), e);
                 if (!sessionManager.isMaskStorageFailure()) {
                     throw new SessionException("Exception saving SPSession record to storage", e);
                 }
@@ -439,8 +439,8 @@
                 // Remove the separate record.

[... 192 lines stripped ...]