[java-opensaml COMMIT] in /trunk/opensaml-saml-impl/src: main/java/org/opensaml/saml/saml2/binding/impl/AddECPRespons...

[noreply at shibboleth.net]

Author: scantor
Date: Mon Jul 14 22:47:42 2014
New Revision: 3946

URL: http://svn.shibboleth.net/view/java-opensaml?rev=3946&view=rev
Log:
IDP-230: add error handling, unit test

Added:
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/saml2/binding/impl/AddECPResponseHeaderHandlerTest.java   (with props)
Modified:
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/impl/AddECPResponseHeaderHandler.java

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/impl/AddECPResponseHeaderHandler.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/impl/AddECPResponseHeaderHandler.java?rev=3946&r1=3945&r2=3946&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/impl/AddECPResponseHeaderHandler.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/binding/impl/AddECPResponseHeaderHandler.java Mon Jul 14 22:47:42 2014
@@ -64,7 +64,7 @@
         try {
             assertionConsumerURL = SAMLBindingSupport.getEndpointURL(messageContext);
         } catch (final BindingException e) {
-            log.debug(getLogPrefix() + " No ACS location available in message context");
+            log.debug("{} No ACS location available in message context", getLogPrefix());
             return false;
         }
         
@@ -81,7 +81,11 @@
         SOAPSupport.addSOAP11MustUnderstandAttribute(header, true);
         SOAPSupport.addSOAP11ActorAttribute(header, ActorBearing.SOAP11_ACTOR_NEXT);
         
-        SOAPSupport.addHeaderBlock(messageContext, header);
+        try {
+            SOAPSupport.addHeaderBlock(messageContext, header);
+        } catch (final Exception e) {
+            throw new MessageHandlerException(e);
+        }
     }
     
 }