[java-identity-provider COMMIT] in /trunk: idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute....

[noreply at shibboleth.net]

Author: rdw
Date: Sun Jul 13 13:31:29 2014
New Revision: 6287

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=6287&view=rev
Log:
Clear up some done/no longer relevant TODO statements

Modified:
    trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java
    trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcher.java
    trunk/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedAttributeDefinitionTest.java
    trunk/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedDataConnectorTest.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/security/credential/BasicInlineCredentialFactoryBean.java
    trunk/idp-profile-spring/src/test/java/net/shibboleth/idp/profile/spring/relyingparty/RelyingPartyGroupTest.java

Modified: trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java?rev=6287&r1=6286&r2=6287&view=diff
==============================================================================
--- trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java (original)
+++ trunk/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java Sun Jul 13 13:31:29 2014
@@ -212,7 +212,6 @@
         clone.setDisplayDescriptions(getDisplayDescriptions());
         clone.setDisplayNames(getDisplayNames());
         clone.setEncoders(getEncoders());
-        // TODO(lajoie): should we clone the values?
         clone.setValues(getValues());
         return clone;
     }

Modified: trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcher.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcher.java?rev=6287&r1=6286&r2=6287&view=diff
==============================================================================
--- trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcher.java (original)
+++ trunk/idp-attribute-filter-impl/src/main/java/net/shibboleth/idp/attribute/filter/matcher/impl/ScriptedMatcher.java Sun Jul 13 13:31:29 2014
@@ -150,7 +150,6 @@
         }
     }
 
-    // TODO : Do we still need these?
     /** {@inheritDoc} */
     @Override public boolean equals(Object obj) {
         if (obj == null) {

Modified: trunk/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedAttributeDefinitionTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedAttributeDefinitionTest.java?rev=6287&r1=6286&r2=6287&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedAttributeDefinitionTest.java (original)
+++ trunk/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedAttributeDefinitionTest.java Sun Jul 13 13:31:29 2014
@@ -107,9 +107,6 @@
         Assert.assertNull(resolvedAttributeDefinition.getActivationCondition());
         Assert.assertFalse(resolvedAttributeDefinition.isPropagateResolutionExceptions());
 
-        //
-        // TODO - do we want to do more about seeing that these are indeed noops?
-        //
         resolvedAttributeDefinition.setDependencyOnly(true);
         resolvedAttributeDefinition.setDisplayDescriptions(null);
         resolvedAttributeDefinition.setDisplayNames(null);

Modified: trunk/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedDataConnectorTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedDataConnectorTest.java?rev=6287&r1=6286&r2=6287&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedDataConnectorTest.java (original)
+++ trunk/idp-attribute-resolver-api/src/test/java/net/shibboleth/idp/attribute/resolver/ResolvedDataConnectorTest.java Sun Jul 13 13:31:29 2014
@@ -36,7 +36,7 @@
  */
 public class ResolvedDataConnectorTest {
 
-    private Map<String, IdPAttribute> resolvedData = Collections.EMPTY_MAP;
+    private final Map<String, IdPAttribute> resolvedData = Collections.EMPTY_MAP;
 
     @Test public void init() {
         MockStaticDataConnector dc = new MockStaticDataConnector();
@@ -114,9 +114,6 @@
         Assert.assertNull(resolvedDataConnector.getActivationCondition());
         Assert.assertFalse(resolvedDataConnector.isPropagateResolutionExceptions());
 
-        //

[... 34 lines stripped ...]