[utilities COMMIT] in /java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component: AbstractIden...

[noreply at shibboleth.net]

Author: rdw
Date: Sun Jul 13 12:57:10 2014
New Revision: 625

URL: http://svn.shibboleth.net/view/utilities?rev=625&view=rev
Log:
IDP-408 remove synchronization from setId.  That is not how we manage access to the ID.

Modified:
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiableInitializableComponent.java
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiedInitializableComponent.java

Modified: java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiableInitializableComponent.java
URL: http://svn.shibboleth.net/view/utilities/java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiableInitializableComponent.java?rev=625&r1=624&r2=625&view=diff
==============================================================================
--- java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiableInitializableComponent.java (original)
+++ java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiableInitializableComponent.java Sun Jul 13 12:57:10 2014
@@ -26,7 +26,7 @@
         implements IdentifiableComponent {
 
     /** {@inheritDoc} */
-    @Override public synchronized void setId(@Nonnull String componentId) {
+    @Override public void setId(@Nonnull String componentId) {
         super.setId(componentId);
     }
 }

Modified: java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiedInitializableComponent.java
URL: http://svn.shibboleth.net/view/utilities/java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiedInitializableComponent.java?rev=625&r1=624&r2=625&view=diff
==============================================================================
--- java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiedInitializableComponent.java (original)
+++ java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/component/AbstractIdentifiedInitializableComponent.java Sun Jul 13 12:57:10 2014
@@ -47,7 +47,7 @@
      * 
      * @param componentId ID of the component
      */
-    protected synchronized void setId(@Nonnull @NotEmpty final String componentId) {
+    protected void setId(@Nonnull @NotEmpty final String componentId) {
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
 
         id = Constraint.isNotNull(StringSupport.trimOrNull(componentId), "Component ID can not be null or empty");