[java-identity-provider COMMIT] in /trunk: idp-authn-api/src/main/java/net/shibboleth/idp/authn/AuthenticationFlowDes...

[noreply at shibboleth.net]

Author: scantor
Date: Tue Feb 25 17:43:00 2014
New Revision: 5477

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=5477&view=rev
Log:
Get rid of redundant constructor parameter.

Modified:
    trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AuthenticationFlowDescriptor.java
    trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/SubjectCanonicalizationFlowDescriptor.java
    trunk/idp-authn-api/src/test/java/net/shibboleth/idp/authn/AuthenticationFlowDescriptorTest.java
    trunk/idp-authn-api/src/test/java/net/shibboleth/idp/authn/context/AuthenticationContextTest.java
    trunk/idp-authn-impl/src/test/java/net/shibboleth/idp/authn/impl/PopulateAuthenticationContextTest.java
    trunk/idp-authn-impl/src/test/java/net/shibboleth/idp/authn/impl/PopulateSubjectCanonicalizationContextTest.java
    trunk/idp-conf/src/main/resources/conf/authn-flow-descriptors.xml
    trunk/idp-conf/src/main/resources/conf/subject-config.xml
    trunk/idp-saml-api/src/main/java/net/shibboleth/idp/saml/nameid/NameIDCanonicalizationFlowDescriptor.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/nameid/CryptoTransientNameIDDecoderTest.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/nameid/CryptoTransientNameIdentifierDecoderTest.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/nameid/NameIDCanonicalizationTest.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/nameid/NameIdentifierCanonicalizationTest.java
    trunk/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/impl/nameid/TransientDecoderTest.java
    trunk/idp-session-impl/src/test/java/net/shibboleth/idp/session/impl/StorageBackedSessionManagerTest.java
    trunk/idp-session-impl/src/test/java/net/shibboleth/idp/session/impl/UpdateSessionWithAuthenticationResultTest.java

Modified: trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AuthenticationFlowDescriptor.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AuthenticationFlowDescriptor.java?rev=5477&r1=5476&r2=5477&view=diff
==============================================================================
--- trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AuthenticationFlowDescriptor.java (original)
+++ trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AuthenticationFlowDescriptor.java Tue Feb 25 17:43:00 2014
@@ -80,13 +80,8 @@
     /** Custom serializer for the results generated by this flow. */
     @Nullable private StorageSerializer<AuthenticationResult> resultSerializer;
 
-    /**
-     * Constructor.
-     * 
-     * @param id unique ID of this flow, cannot be null or empty
-     */
-    public AuthenticationFlowDescriptor(@Nonnull @NotEmpty final String id) {
-        super.setId(id);
+    /** Constructor. */
+    public AuthenticationFlowDescriptor() {
         supportedPrincipals = new Subject();
         inactivityTimeout = 30 * 60 * 1000;
     }

Modified: trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/SubjectCanonicalizationFlowDescriptor.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/SubjectCanonicalizationFlowDescriptor.java?rev=5477&r1=5476&r2=5477&view=diff
==============================================================================
--- trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/SubjectCanonicalizationFlowDescriptor.java (original)
+++ trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/SubjectCanonicalizationFlowDescriptor.java Tue Feb 25 17:43:00 2014
@@ -18,9 +18,7 @@
 package net.shibboleth.idp.authn;
 
 import javax.annotation.Nonnull;
-import javax.security.auth.Subject;
 
-import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
 import net.shibboleth.utilities.java.support.component.AbstractIdentifiableInitializeableComponent;
 import net.shibboleth.utilities.java.support.logic.Constraint;
 
@@ -34,10 +32,11 @@
  * A descriptor for a subject canonicalication flow.
  * 
  * <p>
- * A flow models a sequence of profile actions that performs canonicalization of a {@link Subject} into a string-form
- * principal name. Flows can do essentially anything, including interact with the subject, but must include an
- * activation predicate to indicate their suitability based on the content of the {@link ProfileRequestContext},
- * particularly the required {@link net.shibboleth.idp.authn.context.SubjectCanonicalizationContext} child context.
+ * A flow models a sequence of profile actions that performs canonicalization of a {@link javax.security.auth.Subject}
+ * into a string-form principal name. Flows can do essentially anything, including interact with the subject, but must
+ * include an activation predicate to indicate their suitability based on the content of the
+ * {@link ProfileRequestContext}, particularly the required
+ * {@link net.shibboleth.idp.authn.context.SubjectCanonicalizationContext} child context.
  * </p>
  */

[... 433 lines stripped ...]