[java-identity-provider COMMIT] in /trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl: profile/saml1/Add...
noreply at shibboleth.net
noreply at shibboleth.net
Fri Feb 14 20:45:33 EST 2014
Author: scantor
Date: Fri Feb 14 20:45:32 2014
New Revision: 5383
URL: http://svn.shibboleth.net/view/java-identity-provider?rev=5383&view=rev
Log:
OSJ-62 - relax type casting in message navigation, to avoid class cast errors
Modified:
trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddAuthenticationStatementToAssertion.java
trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddStatusToResponse.java
trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/AddAuthnStatementToAssertion.java
trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/AddStatusToResponse.java
trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/DecryptNameIDs.java
trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml2/ProcessRequestedAuthnContext.java
trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/session/SAML2SPSessionCreationStrategy.java
Modified: trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddAuthenticationStatementToAssertion.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddAuthenticationStatementToAssertion.java?rev=5383&r1=5382&r2=5383&view=diff
==============================================================================
--- trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddAuthenticationStatementToAssertion.java (original)
+++ trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/AddAuthenticationStatementToAssertion.java Fri Feb 14 20:45:32 2014
@@ -78,7 +78,7 @@
* @event {@link IdPEventIds#INVALID_PROFILE_CONFIG}
* @event {@link AuthnEventIds#INVALID_AUTHN_CTX}
*/
-public class AddAuthenticationStatementToAssertion extends AbstractAuthenticationAction<Object, Response> {
+public class AddAuthenticationStatementToAssertion extends AbstractAuthenticationAction {
/** Class logger. */
@Nonnull private final Logger log = LoggerFactory.getLogger(AddAuthenticationStatementToAssertion.class);
@@ -95,7 +95,7 @@
@Nonnull private Function<ProfileRequestContext, RelyingPartyContext> relyingPartyContextLookupStrategy;
/** Strategy used to locate the {@link Response} to operate on. */
- @Nonnull private Function<ProfileRequestContext<Object,Response>, Response> responseLookupStrategy;
+ @Nonnull private Function<ProfileRequestContext, Response> responseLookupStrategy;
/** Strategy used to determine the AuthenticationMethod attribute. */
@Nonnull private Function<ProfileRequestContext, AuthenticationMethodPrincipal> methodLookupStrategy;
@@ -115,7 +115,7 @@
relyingPartyContextLookupStrategy = new ChildContextLookup<>(RelyingPartyContext.class, false);
responseLookupStrategy =
- Functions.compose(new MessageLookup<Response>(), new OutboundMessageContextLookup<Response>());
+ Functions.compose(new MessageLookup<>(Response.class), new OutboundMessageContextLookup());
methodLookupStrategy = new DefaultPrincipalDeterminationStrategy<>(AuthenticationMethodPrincipal.class,
new AuthenticationMethodPrincipal(AuthenticationStatement.UNSPECIFIED_AUTHN_METHOD));
}
@@ -154,7 +154,7 @@
* @param strategy strategy used to locate the {@link Response} to operate on
*/
public synchronized void setResponseLookupStrategy(
- @Nonnull final Function<ProfileRequestContext<Object,Response>, Response> strategy) {
+ @Nonnull final Function<ProfileRequestContext, Response> strategy) {
ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
responseLookupStrategy = Constraint.isNotNull(strategy, "Response lookup strategy cannot be null");
@@ -174,8 +174,7 @@
/** {@inheritDoc} */
@Override
- protected boolean doPreExecute(
- @Nonnull final ProfileRequestContext<Object, Response> profileRequestContext,
+ protected boolean doPreExecute(@Nonnull final ProfileRequestContext profileRequestContext,
@Nonnull final AuthenticationContext authenticationContext) throws AuthenticationException {
log.debug("{} Attempting to add an AuthenticationStatement to outgoing Response", getLogPrefix());
@@ -210,8 +209,7 @@
/** {@inheritDoc} */
@Override
- protected void doExecute(
- @Nonnull final ProfileRequestContext<Object, Response> profileRequestContext,
+ protected void doExecute(@Nonnull final ProfileRequestContext profileRequestContext,
@Nonnull final AuthenticationContext authenticationContext) throws AuthenticationException {
final Assertion assertion = getStatementAssertion();
@@ -227,7 +225,7 @@
*
* @return the assertion to which the attribute statement will be added
*/
- private Assertion getStatementAssertion() {
+ @Nonnull private Assertion getStatementAssertion() {
[... 305 lines stripped ...]
More information about the commits
mailing list