[java-opensaml COMMIT] in /trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core: RequestAbstractType.ja...

[noreply at shibboleth.net]

Author: rdw
Date: Mon Aug 11 04:59:53 2014
New Revision: 3997

URL: http://svn.shibboleth.net/view/java-opensaml?rev=3997&view=rev
Log:
Javadoc and some warning discovered in passing

Modified:
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/RequestAbstractType.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/Response.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/ResponseAbstractType.java

Modified: trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/RequestAbstractType.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/RequestAbstractType.java?rev=3997&r1=3996&r2=3997&view=diff
==============================================================================
--- trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/RequestAbstractType.java (original)
+++ trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/RequestAbstractType.java Mon Aug 11 04:59:53 2014
@@ -18,6 +18,7 @@
 /**
  * 
  */
+
 package org.opensaml.saml.saml1.core;
 
 import java.util.List;
@@ -27,49 +28,68 @@
 import org.opensaml.saml.common.SignableSAMLObject;
 
 /**
- * This interface describes the base class for types derived from
- * <code> RequestAbstractType </code>
+ * This interface describes the base class for types derived from <code> RequestAbstractType </code>.
  */
 public interface RequestAbstractType extends SignableSAMLObject {
 
     /** Name for the attribute which defines the Major Version (which must be "1". */
-    public final static String MAJORVERSION_ATTRIB_NAME = "MajorVersion";
+    public static final String MAJORVERSION_ATTRIB_NAME = "MajorVersion";
 
     /** Name for the attribute which defines the Minor Version. */
-    public final static String MINORVERSION_ATTRIB_NAME = "MinorVersion";
+    public static final String MINORVERSION_ATTRIB_NAME = "MinorVersion";
 
     /** Name for the attribute which defines the Issue Instant. */
-    public final static String ISSUEINSTANT_ATTRIB_NAME = "IssueInstant";
+    public static final String ISSUEINSTANT_ATTRIB_NAME = "IssueInstant";
 
     /** Name for the attribute which defines the Issue Instant. */
-    public final static String ID_ATTRIB_NAME = "RequestID";
+    public static final String ID_ATTRIB_NAME = "RequestID";
 
-    /** 
-     * Gets the SAML version of this message. 
+    /**
+     * Gets the SAML version of this message.
      * 
      * @return the SAML version of this message
      */
     public SAMLVersion getVersion();
-    
+
     /**
      * Sets the SAML version of this message.
      * 
      * @param version SAML version of this message
      */
     public void setVersion(SAMLVersion version);
-      
-    /** Get the issue instant */
+
+    /**
+     * Get the issue instant.
+     * 
+     * @return the issue instant
+     */
     public DateTime getIssueInstant();
- 
-    /** Get the ID */
+
+    /**
+     * Set the issue instant.
+     * 
+     * @param date what to set
+     */
+    public void setIssueInstant(DateTime date);
+
+    /**
+     * Get the ID.
+     * 
+     * @return the ID
+     */
     public String getID();
-    
-    /** Set the ID */
+
+    /**
+     * Set the ID.
+     * 
+     * @param id what to set
+     */
     public void setID(String id);
-    
-    /** Set the issue instant */
-    public void setIssueInstant(DateTime date);
- 
-    /** Return the list of RespondWith elements */
-    public List <RespondWith> getRespondWiths();
+
+    /**
+     * Return the list of RespondWith elements.
+     * 
+     * @return the list of RespondWith elements
+     */
+    public List<RespondWith> getRespondWiths();
 }

Modified: trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/Response.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/Response.java?rev=3997&r1=3996&r2=3997&view=diff
==============================================================================
--- trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/Response.java (original)
+++ trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/saml1/core/Response.java Mon Aug 11 04:59:53 2014
@@ -23,31 +23,45 @@
 
 import org.opensaml.saml.common.xml.SAMLConstants;
 
-
 /**
  * This interface defines how the object representing a SAML1 <code> Response </code> element behaves.
  */
 public interface Response extends ResponseAbstractType {
 
     /** Element name, no namespace. */
-    public final static String DEFAULT_ELEMENT_LOCAL_NAME = "Response";
-    
-    /** Default element name */
-    public final static QName DEFAULT_ELEMENT_NAME = new QName(SAMLConstants.SAML10P_NS, DEFAULT_ELEMENT_LOCAL_NAME, SAMLConstants.SAML1P_PREFIX);
-    
-    /** Local name of the XSI type */
-    public final static String TYPE_LOCAL_NAME = "ResponseAbstractType"; 
-        
-    /** QName of the XSI type */

[... 151 lines stripped ...]