[java-opensaml COMMIT] in /trunk: opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/artifact/impl/Sto...

[noreply at shibboleth.net]

Author: scantor
Date: Fri Aug  8 19:06:02 2014
New Revision: 3993

URL: http://svn.shibboleth.net/view/java-opensaml?rev=3993&view=rev
Log:
Remove implicit setId call from StorageService.

Modified:
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/artifact/impl/StorageServiceSAMLArtifactMapTest.java
    trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/security/impl/MessageReplaySecurityHandlerTest.java
    trunk/opensaml-storage-api/src/main/java/org/opensaml/storage/AbstractStorageService.java
    trunk/opensaml-storage-impl/src/test/java/org/opensaml/storage/impl/JPAStorageServiceTest.java
    trunk/opensaml-storage-impl/src/test/java/org/opensaml/storage/impl/LDAPStorageServiceTest.java
    trunk/opensaml-storage-impl/src/test/java/org/opensaml/storage/impl/MemoryStorageServiceTest.java
    trunk/opensaml-storage-impl/src/test/java/org/opensaml/storage/impl/ReplayCacheTest.java
    trunk/opensaml-storage-impl/src/test/java/org/opensaml/storage/impl/ServletRequestScopedStorageServiceTest.java

Modified: trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/artifact/impl/StorageServiceSAMLArtifactMapTest.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/artifact/impl/StorageServiceSAMLArtifactMapTest.java?rev=3993&r1=3992&r2=3993&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/artifact/impl/StorageServiceSAMLArtifactMapTest.java (original)
+++ trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/artifact/impl/StorageServiceSAMLArtifactMapTest.java Fri Aug  8 19:06:02 2014
@@ -27,7 +27,6 @@
 import org.opensaml.saml.common.SAMLObject;
 import org.opensaml.saml.common.binding.artifact.SAMLArtifactMap.SAMLArtifactMapEntry;
 import org.opensaml.saml.common.binding.artifact.impl.StorageServiceSAMLArtifactMap;
-import org.opensaml.storage.StorageService;
 import org.opensaml.storage.impl.MemoryStorageService;
 import org.testng.Assert;
 import org.testng.annotations.BeforeMethod;
@@ -39,7 +38,7 @@
  */
 public class StorageServiceSAMLArtifactMapTest extends XMLObjectBaseTestCase {
 
-    private StorageService storageService;
+    private MemoryStorageService storageService;
     private StorageServiceSAMLArtifactMap artifactMap;
 
     private String artifact = "the-artifact";
@@ -59,6 +58,7 @@
         samlObject.releaseDOM();
 
         storageService = new MemoryStorageService();
+        storageService.setId("test");
         storageService.initialize();
 
         artifactMap = new StorageServiceSAMLArtifactMap();

Modified: trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/security/impl/MessageReplaySecurityHandlerTest.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/security/impl/MessageReplaySecurityHandlerTest.java?rev=3993&r1=3992&r2=3993&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/security/impl/MessageReplaySecurityHandlerTest.java (original)
+++ trunk/opensaml-saml-impl/src/test/java/org/opensaml/saml/common/binding/security/impl/MessageReplaySecurityHandlerTest.java Fri Aug  8 19:06:02 2014
@@ -27,7 +27,6 @@
 import org.opensaml.saml.common.messaging.context.SAMLMessageInfoContext;
 import org.opensaml.saml.common.messaging.context.SAMLPeerEntityContext;
 import org.opensaml.storage.ReplayCache;
-import org.opensaml.storage.StorageService;
 import org.opensaml.storage.impl.MemoryStorageService;
 import org.testng.annotations.AfterMethod;
 import org.testng.annotations.BeforeMethod;
@@ -44,7 +43,7 @@
 
     private String messageID;
 
-    private StorageService storageService;
+    private MemoryStorageService storageService;
 
     private ReplayCache replayCache;
 
@@ -58,6 +57,7 @@
         messageContext.getSubcontext(SAMLMessageInfoContext.class, true).setMessageId(messageID);
 
         storageService = new MemoryStorageService();
+        storageService.setId("test");
         storageService.initialize();
         
         replayCache = new ReplayCache();

Modified: trunk/opensaml-storage-api/src/main/java/org/opensaml/storage/AbstractStorageService.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-storage-api/src/main/java/org/opensaml/storage/AbstractStorageService.java?rev=3993&r1=3992&r2=3993&view=diff
==============================================================================
--- trunk/opensaml-storage-api/src/main/java/org/opensaml/storage/AbstractStorageService.java (original)
+++ trunk/opensaml-storage-api/src/main/java/org/opensaml/storage/AbstractStorageService.java Fri Aug  8 19:06:02 2014
@@ -69,15 +69,6 @@
     @Positive private int valueSize;
 
     /**
-     * Constructor.
-     * 
-     */
-    public AbstractStorageService() {
-        // TODO(RDW) Implict setID.

[... 137 lines stripped ...]