[java-identity-provider COMMIT] in /trunk: idp-conf/src/main/resources/system/conf/services-system.xml idp-session-im...

[noreply at shibboleth.net]

Author: rdw
Date: Thu Aug  7 12:46:03 2014
New Revision: 6404

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=6404&view=rev
Log:
IDP-463 Warn where there is an implicit setId.  Name Beans, not the components.

Modified:
    trunk/idp-conf/src/main/resources/system/conf/services-system.xml
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java

Modified: trunk/idp-conf/src/main/resources/system/conf/services-system.xml
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-conf/src/main/resources/system/conf/services-system.xml?rev=6404&r1=6403&r2=6404&view=diff
==============================================================================
--- trunk/idp-conf/src/main/resources/system/conf/services-system.xml (original)
+++ trunk/idp-conf/src/main/resources/system/conf/services-system.xml Thu Aug  7 12:46:03 2014
@@ -30,7 +30,7 @@
             value="net.shibboleth.idp.attribute.filter.AttributeFilter" />
         <constructor-arg name="strategy">
             <bean class="net.shibboleth.idp.attribute.filter.spring.AttributeFilterServiceStrategy"
-                p:id="ShibbolethAttributeFilter"/>
+                id="ShibbolethAttributeFilter"/>
         </constructor-arg>
     </bean>
 
@@ -44,7 +44,7 @@
             value="net.shibboleth.idp.attribute.resolver.AttributeResolver" />
         <constructor-arg name="strategy">
             <bean class="net.shibboleth.idp.attribute.resolver.spring.AttributeResolverServiceStrategy"
-                p:id="ShibbolethAttributeResolver"/>
+                id="ShibbolethAttributeResolver"/>
         </constructor-arg>
     </bean>
 

Modified: trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java?rev=6404&r1=6403&r2=6404&view=diff
==============================================================================
--- trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java (original)
+++ trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java Thu Aug  7 12:46:03 2014
@@ -176,6 +176,7 @@
         consistentAddress = true;
         cookieName = DEFAULT_COOKIE_NAME;
 
+        // TODO(RDW) Implict setId
         setId(UUID.randomUUID().toString());
     }