[java-opensaml COMMIT] in /trunk: opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/SchemaVal...

[noreply at shibboleth.net]

Author: tzeller
Date: Mon Aug  4 13:33:34 2014
New Revision: 3986

URL: http://svn.shibboleth.net/view/java-opensaml?rev=3986&view=rev
Log:
IDP-456 Cleanup logging of exceptions with parameterized messages.

Modified:
    trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/SchemaValidateXMLMessage.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/security/impl/BaseSAMLSimpleSignatureSecurityHandler.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/security/impl/SAMLProtocolMessageXMLSignatureSecurityHandler.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/profile/impl/SignAssertions.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/AddSubjectConfirmationToSubjects.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/DecryptAssertions.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/DecryptAttributes.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/DecryptNameIDs.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/EncryptAssertions.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/EncryptAttributes.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/EncryptNameIDs.java

Modified: trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/SchemaValidateXMLMessage.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/SchemaValidateXMLMessage.java?rev=3986&r1=3985&r2=3986&view=diff
==============================================================================
--- trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/SchemaValidateXMLMessage.java (original)
+++ trunk/opensaml-messaging-impl/src/main/java/org/opensaml/messaging/handler/impl/SchemaValidateXMLMessage.java Mon Aug  4 13:33:34 2014
@@ -95,11 +95,11 @@
             final Validator schemaValidator = validationSchema.newValidator();
             schemaValidator.validate(new DOMSource(messageContext.getMessage().getDOM()));
         } catch (SAXException e) {
-            log.debug(getLogPrefix() + " Message " + messageContext.getMessage().getElementQName()
-                    + " is not schema-valid", e);
+            log.debug("{} Message {} is not schema-valid", getLogPrefix(), messageContext.getMessage()
+                    .getElementQName(), e);
             throw new MessageHandlerException("Message is not schema-valid.", e);
         } catch (IOException e) {
-            log.debug(getLogPrefix() + " Unable to read message", e);
+            log.debug("{} Unable to read message", getLogPrefix(), e);
             throw new MessageHandlerException("Unable to read message.", e);
         }
 

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/security/impl/BaseSAMLSimpleSignatureSecurityHandler.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/security/impl/BaseSAMLSimpleSignatureSecurityHandler.java?rev=3986&r1=3985&r2=3986&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/security/impl/BaseSAMLSimpleSignatureSecurityHandler.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/security/impl/BaseSAMLSimpleSignatureSecurityHandler.java Mon Aug  4 13:33:34 2014
@@ -298,7 +298,7 @@
                 return false;
             }
         } catch (SecurityException e) {
-            log.warn(getLogPrefix() + " Error evaluating the request's simple signature using the trust engine", e);
+            log.warn("{} Error evaluating the request's simple signature using the trust engine", getLogPrefix(), e);
             throw new MessageHandlerException("Error during trust engine evaluation of the simple signature", e);
         }
     }

Modified: trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/security/impl/SAMLProtocolMessageXMLSignatureSecurityHandler.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/security/impl/SAMLProtocolMessageXMLSignatureSecurityHandler.java?rev=3986&r1=3985&r2=3986&view=diff
==============================================================================
--- trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/security/impl/SAMLProtocolMessageXMLSignatureSecurityHandler.java (original)
+++ trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/security/impl/SAMLProtocolMessageXMLSignatureSecurityHandler.java Mon Aug  4 13:33:34 2014
@@ -163,7 +163,7 @@
             try {
                 getSignaturePrevalidator().validate(signature);
             } catch (SignatureException e) {

[... 181 lines stripped ...]