[utilities COMMIT] /spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java

noreply at shibboleth.net noreply at shibboleth.net
Mon Aug 4 12:33:56 EDT 2014


Author: tzeller
Date: Mon Aug  4 12:33:55 2014
New Revision: 651

URL: http://svn.shibboleth.net/view/utilities?rev=651&view=rev
Log:
IDP-456 Fix logging of exceptions with parameterized messages.

Modified:
    spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java

Modified: spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java
URL: http://svn.shibboleth.net/view/utilities/spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java?rev=651&r1=650&r2=651&view=diff
==============================================================================
--- spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java (original)
+++ spring-extensions/trunk/src/main/java/net/shibboleth/ext/spring/resource/FileBackedHTTPResource.java Mon Aug  4 12:33:55 2014
@@ -102,7 +102,7 @@
         } catch (IOException e) {
             // try to tidy up
             backingResource.getFile().delete();
-            log.error("{}: Copy failed: {}", getDescription(), e);
+            log.error("{}: Copy failed", getDescription(), e);
             throw e;
         }
         return new FileInputStream(backingResource.getFile());
@@ -119,7 +119,7 @@
             try {
                 return new FileInputStream(backingResource.getFile());
             } catch (IOException e) {
-                log.error("FileBackedHTTPResource {}: Could not read backing file: {}", getDescription(), e);
+                log.error("FileBackedHTTPResource {}: Could not read backing file", getDescription(), e);
                 throw e;
             }
         }
@@ -133,7 +133,7 @@
         try {
             response = getResourceHeaders();
         } catch (IOException e) {
-            log.info("{}: Could not reach URL:{}, trying file", getDescription(), e);
+            log.info("{}: Could not reach URL, trying file", getDescription(), e);
             return backingResource.exists();
         }
         int httpStatusCode = response.getStatusLine().getStatusCode();
@@ -150,7 +150,7 @@
         try {
             return super.contentLength();
         } catch (IOException e) {
-            log.info("{}: Could not reach URL:{}, trying file", getDescription(), e);
+            log.info("{}: Could not reach URL, trying file", getDescription(), e);
             return backingResource.contentLength();
         }
     }
@@ -160,7 +160,7 @@
         try {
             return super.lastModified();
         } catch (IOException e) {
-            log.info("{}: Could not reach URL:{}, trying file", getDescription(), e);
+            log.info("{}: Could not reach URL, trying file", getDescription(), e);
             return backingResource.lastModified();
         }
     }



More information about the commits mailing list