[java-identity-provider COMMIT] /trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/...

[noreply at shibboleth.net]

Author: rdw
Date: Mon Aug  4 10:52:46 2014
New Revision: 6385

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=6385&view=rev
Log:
IDP-354 Comment on the documented use of getAttributeAsBoolean

Modified:
    trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/AttributeRuleParser.java

Modified: trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/AttributeRuleParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/AttributeRuleParser.java?rev=6385&r1=6384&r2=6385&view=diff
==============================================================================
--- trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/AttributeRuleParser.java (original)
+++ trunk/idp-attribute-filter-spring/src/main/java/net/shibboleth/idp/attribute/filter/spring/AttributeRuleParser.java Mon Aug  4 10:52:46 2014
@@ -137,7 +137,7 @@
             builder.addPropertyValue("isDenyRule", true);
         } else if (config.hasAttributeNS(null, PERMIT_ANY_ATTRIBUTE)
                 && AttributeSupport.getAttributeValueAsBoolean(config.getAttributeNodeNS(null, PERMIT_ANY_ATTRIBUTE))) {
-
+            // Note the documented restriction that permitAny cannot be property replaced.
             builder.addPropertyValue("isDenyRule", false);
             builder.addPropertyValue("matcher", Matcher.MATCHES_ALL);
         } else {