[java-identity-provider COMMIT] in /trunk/idp-profile-spring/src: main/java/net/shibboleth/idp/profile/spring/relying...

[noreply at shibboleth.net]

Author: rdw
Date: Wed Apr 30 05:53:17 2014
New Revision: 5804

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=5804&view=rev
Log:
IDP-390 Cleanup.  Remove redundant warnings and done TODOs

Modified:
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/AbstractRelyingPartyParser.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/RelyingPartyGroupParser.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/MetadataNamespaceHandler.java
    trunk/idp-profile-spring/src/test/java/net/shibboleth/idp/profile/spring/relyingparty/RelyingPartyGroupTest.java
    trunk/idp-profile-spring/src/test/java/net/shibboleth/idp/profile/spring/relyingparty/RelyingPartyTest.java

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/AbstractRelyingPartyParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/AbstractRelyingPartyParser.java?rev=5804&r1=5803&r2=5804&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/AbstractRelyingPartyParser.java (original)
+++ trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/AbstractRelyingPartyParser.java Wed Apr 30 05:53:17 2014
@@ -21,14 +21,11 @@
 
 import javax.xml.namespace.QName;
 
-import net.shibboleth.idp.profile.spring.relyingparty.saml.SAML2ArtifactResolutionProfileParser;
 import net.shibboleth.idp.relyingparty.RelyingPartyConfiguration;
 import net.shibboleth.idp.spring.SpringSupport;
 import net.shibboleth.utilities.java.support.primitive.StringSupport;
 import net.shibboleth.utilities.java.support.xml.ElementSupport;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.config.BeanDefinition;
 import org.springframework.beans.factory.support.BeanDefinitionBuilder;
 import org.springframework.beans.factory.xml.AbstractSingleBeanDefinitionParser;
@@ -46,9 +43,6 @@
     public static final QName PROFILE_CONFIGURATION = new QName(RelyingPartyNamespaceHandler.NAMESPACE,
             "ProfileConfiguration");
 
-    /** logger. */
-    private Logger log = LoggerFactory.getLogger(SAML2ArtifactResolutionProfileParser.class);
-
     /** {@inheritDoc} */
     @Override protected java.lang.Class<RelyingPartyConfiguration> getBeanClass(Element element) {
         return RelyingPartyConfiguration.class;
@@ -58,11 +52,7 @@
     @Override protected void doParse(Element element, ParserContext parserContext, BeanDefinitionBuilder builder) {
         super.doParse(element, parserContext, builder);
 
-        if (element.hasAttributeNS(null, "defaultSigningCredentialRef")) {
-            // TODO
-            log.warn("I do not (yet) know how to deal with 'defaultSigningCredentialRef=\"{}\"'",
-                    element.getAttributeNS(null, "defaultSigningCredentialRef"));
-        }
+        // defaultSigningCredentialRef
         // defaultAuthenticationMethod and nameIDFormatPrecedence is dealt with in the specific SSO
         // profileConfigurations
 

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/RelyingPartyGroupParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/RelyingPartyGroupParser.java?rev=5804&r1=5803&r2=5804&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/RelyingPartyGroupParser.java (original)
+++ trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/RelyingPartyGroupParser.java Wed Apr 30 05:53:17 2014
@@ -36,10 +36,8 @@
 import org.w3c.dom.Element;
 
 /**
- * TODO Security.
- * 
  * Parser for &lt;AnonymousRelyingParty&gt;<br/>
- * This parser summons up two (TODO three) beans a {@link DefaultRelyingPartyConfigurationResolver} which deals with the
+ * This parser summons up two beans: a {@link DefaultRelyingPartyConfigurationResolver} which deals with the
  * RelyingParty bit of the file, a series of {@link RelyingPartyMetadataProvider}s which deal with the metadata
  * configuration and a series of {@link TBD} which deals with the security configuration.
  */
@@ -113,7 +111,7 @@
         SpringSupport.parseCustomElements(configChildren.get(SecurityNamespaceHandler.CREDENTIAL_ELEMENT_NAME),
                 parserContext);
         // TODO Security
-        // <TrustEngine> (for metadata>
+        // <TrustEngine> (for metadata)
         // <SecurityPolicy> (warn and ignore).
 
     }

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/MetadataNamespaceHandler.java

[... 41 lines stripped ...]