[java-opensaml COMMIT] in /trunk: opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/BasicSAML...

[noreply at shibboleth.net]

Author: scantor
Date: Mon Apr 28 11:35:20 2014
New Revision: 3820

URL: http://svn.shibboleth.net/view/java-opensaml?rev=3820&view=rev
Log:
Bit of cleanup

Modified:
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/BasicSAMLArtifactMapEntry.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/ExpiringSAMLArtifactMapEntry.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/SAMLArtifactMap.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/artifact/impl/BasicSAMLArtifactMap.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/artifact/impl/ExpiringSAMLArtifactMapEntryFactory.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/artifact/impl/StorageServiceSAMLArtifactMap.java
    trunk/opensaml-saml-impl/src/main/java/org/opensaml/saml/common/binding/artifact/impl/StorageServiceSAMLArtifactMapEntryFactory.java

Modified: trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/BasicSAMLArtifactMapEntry.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/BasicSAMLArtifactMapEntry.java?rev=3820&r1=3819&r2=3820&view=diff
==============================================================================
--- trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/BasicSAMLArtifactMapEntry.java (original)
+++ trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/BasicSAMLArtifactMapEntry.java Mon Apr 28 11:35:20 2014
@@ -66,21 +66,25 @@
     }
 
     /** {@inheritDoc} */
+    @Override
     @Nonnull @NotEmpty public String getArtifact() {
         return artifact;
     }
 
     /** {@inheritDoc} */
+    @Override
     @Nonnull @NotEmpty public String getIssuerId() {
         return issuer;
     }
 
     /** {@inheritDoc} */
+    @Override
     @Nonnull @NotEmpty public String getRelyingPartyId() {
         return relyingParty;
     }
 
     /** {@inheritDoc} */
+    @Override
     @Nonnull public SAMLObject getSamlMessage() {
         return message;
     }

Modified: trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/ExpiringSAMLArtifactMapEntry.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/ExpiringSAMLArtifactMapEntry.java?rev=3820&r1=3819&r2=3820&view=diff
==============================================================================
--- trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/ExpiringSAMLArtifactMapEntry.java (original)
+++ trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/ExpiringSAMLArtifactMapEntry.java Mon Apr 28 11:35:20 2014
@@ -62,7 +62,7 @@
      * 
      * @param exp the expiration
      */
-    public void setExpiration(long exp) {
+    public void setExpiration(final long exp) {
         expiration = exp;
     }
     
@@ -81,7 +81,7 @@
      * @param effectiveTime the time to evaluate validity against
      * @return true iff the entry is valid as of a specified time
      */
-    public boolean isValid(long effectiveTime) {
+    public boolean isValid(final long effectiveTime) {
         return effectiveTime < expiration;
     }
 }

Modified: trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/SAMLArtifactMap.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/SAMLArtifactMap.java?rev=3820&r1=3819&r2=3820&view=diff
==============================================================================
--- trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/SAMLArtifactMap.java (original)
+++ trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/SAMLArtifactMap.java Mon Apr 28 11:35:20 2014
@@ -51,7 +51,7 @@
      * @return true iff this map has an entry for the given artifact
      * @throws IOException if an error occurs retrieving the information
      */
-    public boolean contains(@Nonnull @NotEmpty final String artifact) throws IOException;
+    boolean contains(@Nonnull @NotEmpty final String artifact) throws IOException;
 
     /**
      * Creates a mapping between a given artifact and the SAML message to which it maps.
@@ -63,7 +63,7 @@
      * 
      * @throws IOException if an error occurs storing the information
      */
-    public void put(@Nonnull @NotEmpty final String artifact, @Nonnull @NotEmpty final String relyingPartyId,
+    void put(@Nonnull @NotEmpty final String artifact, @Nonnull @NotEmpty final String relyingPartyId,
             @Nonnull @NotEmpty final String issuerId, @Nonnull final SAMLObject samlMessage) throws IOException;
 
     /**
@@ -74,7 +74,7 @@
      * @return the entry, or null if the artifact has already expired or did not exist

[... 323 lines stripped ...]