[java-identity-provider COMMIT] in /trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring: relying...

[noreply at shibboleth.net]

Author: rdw
Date: Thu Apr 24 13:00:39 2014
New Revision: 5770

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=5770&view=rev
Log:
IDP-390 Clean up error handling.  Log all failures at error as well as throwing an exception.

Modified:
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/AbstractMetadataProviderParser.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/ResourceBackedMetadataProviderParser.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/filter/SignatureValidationParser.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/security/credential/AbstractBasicCredentialFactoryBean.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/security/credential/AbstractBasicCredentialParser.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/security/credential/AbstractCredentialFactoryBean.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/security/credential/AbstractX509CredentialFactoryBean.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/security/credential/BasicFilesystemCredentialFactoryBean.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/security/credential/X509FilesystemCredentialFactoryBean.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/security/credential/X509InlineCredentialFactoryBean.java
    trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/resource/ResourceNamespaceHandler.java

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/AbstractMetadataProviderParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/AbstractMetadataProviderParser.java?rev=5770&r1=5769&r2=5770&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/AbstractMetadataProviderParser.java (original)
+++ trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/AbstractMetadataProviderParser.java Thu Apr 24 13:00:39 2014
@@ -85,16 +85,22 @@
         }
 
         if (element.hasAttributeNS(null, "maxCacheDuration")) {
+            log.error("{}: maxCacheDuration is not supported", parserContext.getReaderContext().getResource()
+                    .getDescription());
             throw new BeanDefinitionParsingException(new Problem("maxCacheDuration is not supported", new Location(
                     parserContext.getReaderContext().getResource())));
         }
 
         if (element.hasAttributeNS(null, "cacheDuration")) {
+            log.error("{}: cacheDuration is not supported", parserContext.getReaderContext().getResource()
+                    .getDescription());
             throw new BeanDefinitionParsingException(new Problem("cacheDuration is not supported", new Location(
                     parserContext.getReaderContext().getResource())));
         }
 
         if (element.hasAttributeNS(null, "maintainExpiredMetadata")) {
+            log.error("{}: maintainExpiredMetadata is not supported", parserContext.getReaderContext().getResource()
+                    .getDescription());
             throw new BeanDefinitionParsingException(new Problem("maintainExpiredMetadata is not supported",
                     new Location(parserContext.getReaderContext().getResource())));
         }

Modified: trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/ResourceBackedMetadataProviderParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/ResourceBackedMetadataProviderParser.java?rev=5770&r1=5769&r2=5770&view=diff
==============================================================================
--- trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/ResourceBackedMetadataProviderParser.java (original)
+++ trunk/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/relyingparty/metadata/ResourceBackedMetadataProviderParser.java Thu Apr 24 13:00:39 2014
@@ -69,6 +69,7 @@
         }
         final QName qName = DomTypeSupport.getXSIType(resources.get(0));
         if (null == qName) {
+            log.error("No type specified for a <Resource> within a ResourceBackedMetadataProvider");
             throw new BeanCreationException(
                     "No type specified for a <Resource> within a ResourceBackedMetadataProvider");
         }
@@ -86,6 +87,7 @@

[... 627 lines stripped ...]