[java-identity-provider COMMIT] in /trunk: idp-authn-api/src/main/java/net/shibboleth/idp/authn/BaseAuthenticationRes...

noreply at shibboleth.net noreply at shibboleth.net
Thu Sep 26 00:20:32 EDT 2013


Author: scantor
Date: Thu Sep 26 00:20:32 2013
New Revision: 4800

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4800&view=rev
Log:
Align some base class names to conventions, and more session impl work.

Added:
    trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/DefaultAuthenticationResultSerializer.java
      - copied, changed from r4797, trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/BaseAuthenticationResultSerializer.java
    trunk/idp-authn-api/src/test/java/net/shibboleth/idp/authn/DefaultAuthenticationResultSerializerTest.java
      - copied, changed from r4797, trunk/idp-authn-api/src/test/java/net/shibboleth/idp/authn/BaseAuthenticationResultSerializerTest.java
    trunk/idp-session-api/src/main/java/net/shibboleth/idp/session/AbstractIdPSession.java
      - copied, changed from r4795, trunk/idp-session-api/src/main/java/net/shibboleth/idp/session/BaseIdPSession.java
Modified:
    trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/BaseAuthenticationResultSerializer.java
    trunk/idp-authn-api/src/test/java/net/shibboleth/idp/authn/BaseAuthenticationResultSerializerTest.java
    trunk/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractActiveAuthenticationResults.java
    trunk/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/UpdateSessionWithAuthenticationResult.java
    trunk/idp-authn-impl/src/main/resources/flows/authn-flow-descriptors.xml
    trunk/idp-session-api/src/main/java/net/shibboleth/idp/session/BaseIdPSession.java
    trunk/idp-session-api/src/main/java/net/shibboleth/idp/session/IdPSession.java
    trunk/idp-session-api/src/main/java/net/shibboleth/idp/session/context/SessionContext.java
    trunk/idp-session-api/src/test/java/net/shibboleth/idp/session/IdPSessionTest.java
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedIdPSession.java
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedIdPSessionSerializer.java
    trunk/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java

Copied: trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/DefaultAuthenticationResultSerializer.java (from r4797, trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/BaseAuthenticationResultSerializer.java)
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/DefaultAuthenticationResultSerializer.java?p2=trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/DefaultAuthenticationResultSerializer.java&p1=trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/BaseAuthenticationResultSerializer.java&r1=4797&r2=4800&rev=4800&view=diff
==============================================================================
--- trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/BaseAuthenticationResultSerializer.java (original)
+++ trunk/idp-authn-api/src/main/java/net/shibboleth/idp/authn/DefaultAuthenticationResultSerializer.java Thu Sep 26 00:20:32 2013
@@ -57,10 +57,6 @@
 import com.google.common.collect.HashBiMap;
 import com.google.common.collect.ImmutableBiMap;
 
-// Checkstyle: AbstractClassName OFF
-// My preferred name would be "BasicAuthenticationResultSerializer", but that causes confusion with
-// the term "Basic Authentication" in HTTP.
-
 /**
  * Handles serialization of results that carry only custom {@link Principal} objects of a simple
  * nature that can be reconstructed via a String-argument constructor.
@@ -68,7 +64,7 @@
  * <p>The expiration of the resulting record <strong>MUST</strong> be set to the last activity
  * instant of the object plus an optional offset value supplied to the constructor.</p>
  */
-public class BaseAuthenticationResultSerializer implements StorageSerializer<AuthenticationResult> {
+public class DefaultAuthenticationResultSerializer implements StorageSerializer<AuthenticationResult> {
 
     /** Field name of Flow ID. */
     private static final String FLOW_ID_FIELD = "id";
@@ -89,7 +85,7 @@
     private static final String USERNAME_FIELD = "U";
     
     /** Class logger. */
-    @Nonnull private final Logger log = LoggerFactory.getLogger(BaseAuthenticationResultSerializer.class);
+    @Nonnull private final Logger log = LoggerFactory.getLogger(DefaultAuthenticationResultSerializer.class);
     
     /** Milliseconds to substract from record expiration to establish last activity value. */
     @Duration @NonNegative private final long expirationOffset;
@@ -105,7 +101,7 @@
      *
      * @param offset milliseconds to substract from record expiration to establish last activity value
      */
-    public BaseAuthenticationResultSerializer(@Duration @NonNegative final long offset) {
+    public DefaultAuthenticationResultSerializer(@Duration @NonNegative final long offset) {
         symbolics = ImmutableBiMap.of();
         compatiblePrincipalTypes = Collections.synchronizedSet(new HashSet<Class<? extends Principal>>());

[... 836 lines stripped ...]


More information about the commits mailing list