[utilities COMMIT] /java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/CookieBufferingFilter....

[noreply at shibboleth.net]

Author: scantor
Date: Tue Oct 29 11:45:48 2013
New Revision: 468

URL: http://svn.shibboleth.net/view/utilities?rev=468&view=rev
Log:
Remove TODO.

Modified:
    java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/CookieBufferingFilter.java

Modified: java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/CookieBufferingFilter.java
URL: http://svn.shibboleth.net/view/utilities/java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/CookieBufferingFilter.java?rev=468&r1=467&r2=468&view=diff
==============================================================================
--- java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/CookieBufferingFilter.java (original)
+++ java-support/trunk/src/main/java/net/shibboleth/utilities/java/support/net/CookieBufferingFilter.java Tue Oct 29 11:45:48 2013
@@ -70,12 +70,7 @@
                 new CookieBufferingHttpServletResponseProxy((HttpServletResponse) response);
         chain.doFilter(request, responseProxy);
         
-        // TODO: I don't think this is going to work, this would run post-response generation
-        // so the headers should already be sent. Should be easy to tell, since no cookies will
-        // get set. If so, I think we have to catch all of the potential "body writing" methods
-        // in the wrapper and dump the cookies at that point from the wrapper.
-        
-        // Dump all the cookies set into the real response.
+        // Dump all the cookies set into the real response if not done already.
         responseProxy.dumpCookies();
     }