[java-xmltooling COMMIT] in /branches/REL_1: doc/RELEASE-NOTES.txt src/main/java/org/opensaml/xml/util/AttributeMap.java

[noreply at shibboleth.net]

Author: putmanb
Date: Wed Oct 23 20:27:17 2013
New Revision: 811

URL: http://svn.shibboleth.net/view/java-xmltooling?rev=811&view=rev
Log:
JXT-103: XMLTooling failed to pass veracode due Use of Wrong Operator in String Comparison (CWE ID 597).
And also port forward to v3.

Modified:
    branches/REL_1/doc/RELEASE-NOTES.txt
    branches/REL_1/src/main/java/org/opensaml/xml/util/AttributeMap.java

Modified: branches/REL_1/doc/RELEASE-NOTES.txt
URL: http://svn.shibboleth.net/view/java-xmltooling/branches/REL_1/doc/RELEASE-NOTES.txt?rev=811&r1=810&r2=811&view=diff
==============================================================================
--- branches/REL_1/doc/RELEASE-NOTES.txt (original)
+++ branches/REL_1/doc/RELEASE-NOTES.txt Wed Oct 23 20:27:17 2013
@@ -1,6 +1,7 @@
 Changes in Release 1.4.1
 =============================================
 [JXT-102] - Decrypter should be defensive about Santuario and Java crypto classes throwing unchecked exceptions 
+[JXT-103] - XMLTooling failed to pass veracode due Use of Wrong Operator in String Comparison (CWE ID 597) 
 
 Changes in Release 1.4.0
 =============================================

Modified: branches/REL_1/src/main/java/org/opensaml/xml/util/AttributeMap.java
URL: http://svn.shibboleth.net/view/java-xmltooling/branches/REL_1/src/main/java/org/opensaml/xml/util/AttributeMap.java?rev=811&r1=810&r2=811&view=diff
==============================================================================
--- branches/REL_1/src/main/java/org/opensaml/xml/util/AttributeMap.java (original)
+++ branches/REL_1/src/main/java/org/opensaml/xml/util/AttributeMap.java Wed Oct 23 20:27:17 2013
@@ -83,7 +83,7 @@
     /** {@inheritDoc} */
     public String put(QName attributeName, String value) {
         String oldValue = get(attributeName);
-        if (value != oldValue) {
+        if (!DatatypeHelper.safeEquals(value, oldValue)) {
             releaseDOM();
             attributes.put(attributeName, value);
             if (isIDAttribute(attributeName) || Configuration.isIDAttribute(attributeName)) {