[java-identity-provider COMMIT] in /trunk/idp-core/src/main/java/net/shibboleth/idp: StatusServlet.java predicate/Scr...

[noreply at shibboleth.net]

Author: rdw
Date: Sun Nov 24 08:59:49 2013
New Revision: 4963

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4963&view=rev
Log:
CheckStyle

Added:
    trunk/idp-core/src/main/java/net/shibboleth/idp/spring/resource/package-info.java   (with props)
Modified:
    trunk/idp-core/src/main/java/net/shibboleth/idp/StatusServlet.java
    trunk/idp-core/src/main/java/net/shibboleth/idp/predicate/ScriptedPredicate.java
    trunk/idp-core/src/main/java/net/shibboleth/idp/service/AbstractSpringReloadableService.java
    trunk/idp-core/src/main/java/net/shibboleth/idp/spring/resource/AbstractResourceBeanDefinitionParser.java

Modified: trunk/idp-core/src/main/java/net/shibboleth/idp/StatusServlet.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-core/src/main/java/net/shibboleth/idp/StatusServlet.java?rev=4963&r1=4962&r2=4963&view=diff
==============================================================================
--- trunk/idp-core/src/main/java/net/shibboleth/idp/StatusServlet.java (original)
+++ trunk/idp-core/src/main/java/net/shibboleth/idp/StatusServlet.java Sun Nov 24 08:59:49 2013
@@ -81,7 +81,8 @@
     }
 
     /** {@inheritDoc} */
-    protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
+    protected void doGet(HttpServletRequest request, HttpServletResponse response) 
+            throws ServletException, IOException {
         if (!isAuthenticated(request)) {
             // TODO do we need commons httpclient ?
             // response.sendError(HttpStatus.SC_UNAUTHORIZED);

Modified: trunk/idp-core/src/main/java/net/shibboleth/idp/predicate/ScriptedPredicate.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-core/src/main/java/net/shibboleth/idp/predicate/ScriptedPredicate.java?rev=4963&r1=4962&r2=4963&view=diff
==============================================================================
--- trunk/idp-core/src/main/java/net/shibboleth/idp/predicate/ScriptedPredicate.java (original)
+++ trunk/idp-core/src/main/java/net/shibboleth/idp/predicate/ScriptedPredicate.java Sun Nov 24 08:59:49 2013
@@ -37,7 +37,7 @@
 import com.google.common.base.Predicate;
 
 /**
- *
+ * TODO - remove?
  */
 public class ScriptedPredicate implements Predicate<BaseContext> {
 

Modified: trunk/idp-core/src/main/java/net/shibboleth/idp/service/AbstractSpringReloadableService.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-core/src/main/java/net/shibboleth/idp/service/AbstractSpringReloadableService.java?rev=4963&r1=4962&r2=4963&view=diff
==============================================================================
--- trunk/idp-core/src/main/java/net/shibboleth/idp/service/AbstractSpringReloadableService.java (original)
+++ trunk/idp-core/src/main/java/net/shibboleth/idp/service/AbstractSpringReloadableService.java Sun Nov 24 08:59:49 2013
@@ -225,6 +225,7 @@
     }
     
     /** {@inheritDoc} */
+    // Checkstyle: CyclomaticComplexity OFF
     protected boolean shouldReload() {
         // Loop over each resource and check if the any resources have been changed since
         // the last time the service was reloaded. I believe a read lock is all we need here
@@ -286,5 +287,5 @@
             readLock.unlock();
         }
     }
-
+    // Checkstyle: CyclomaticComplexity ON
 }

Modified: trunk/idp-core/src/main/java/net/shibboleth/idp/spring/resource/AbstractResourceBeanDefinitionParser.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-core/src/main/java/net/shibboleth/idp/spring/resource/AbstractResourceBeanDefinitionParser.java?rev=4963&r1=4962&r2=4963&view=diff
==============================================================================
--- trunk/idp-core/src/main/java/net/shibboleth/idp/spring/resource/AbstractResourceBeanDefinitionParser.java (original)
+++ trunk/idp-core/src/main/java/net/shibboleth/idp/spring/resource/AbstractResourceBeanDefinitionParser.java Sun Nov 24 08:59:49 2013
@@ -29,7 +29,8 @@
         //List<Element> resFilter = XMLHelper.getChildElementsByTagNameNS(element, ResourceNamespaceHandler.NAMESPACE,
         //        "ResourceFilter");
         //if (!resFilter.isEmpty()) {
-        //    builder.addPropertyValue("resourceFilter", SpringConfigurationUtils.parseInnerCustomElement(resFilter.get(0), parserContext));
+        //    builder.addPropertyValue("resourceFilter", 
+    // SpringConfigurationUtils.parseInnerCustomElement(resFilter.get(0), parserContext));
         //}
         // return null;
     // }