[java-opensaml COMMIT] in /trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common: AbstractSAMLObject.java Ab...

[noreply at shibboleth.net]

Author: scantor
Date: Mon Nov 11 15:42:59 2013
New Revision: 3499

URL: http://svn.shibboleth.net/view/java-opensaml?rev=3499&view=rev
Log:
Annotations and warnings.

Added:
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/package-info.java   (with props)
Modified:
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObject.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectBuilder.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectMarshaller.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectUnmarshaller.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSignableSAMLObject.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLException.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectBuilder.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectContentReference.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLObjectSupport.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLRuntimeException.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SAMLVersion.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/SignableSAMLObject.java
    trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/package.html

Modified: trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObject.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObject.java?rev=3499&r1=3498&r2=3499&view=diff
==============================================================================
--- trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObject.java (original)
+++ trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObject.java Mon Nov 11 15:42:59 2013
@@ -17,6 +17,9 @@
 
 package org.opensaml.saml.common;
 
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+
 import org.joda.time.DateTime;
 import org.joda.time.DateTimeZone;
 import org.opensaml.core.xml.AbstractXMLObject;
@@ -33,7 +36,8 @@
      * @param elementLocalName the local name of the XML element this Object represents
      * @param namespacePrefix the prefix for the given namespace
      */
-    protected AbstractSAMLObject(String namespaceURI, String elementLocalName, String namespacePrefix) {
+    protected AbstractSAMLObject(@Nullable final String namespaceURI, @Nonnull final String elementLocalName,
+            @Nullable final String namespacePrefix) {
         super(namespaceURI, elementLocalName, namespacePrefix);
     }
 
@@ -64,7 +68,8 @@
      * 
      * @return The value to assign to the saved Object.
      */
-    protected DateTime prepareForAssignment(DateTime oldValue, DateTime newValue) {
+    @Nullable protected DateTime prepareForAssignment(@Nullable final DateTime oldValue,
+            @Nullable final DateTime newValue) {
         DateTime utcValue = null;
         if (newValue != null) {
             utcValue = newValue.withZone(DateTimeZone.UTC);

Modified: trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectBuilder.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectBuilder.java?rev=3499&r1=3498&r2=3499&view=diff
==============================================================================
--- trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectBuilder.java (original)
+++ trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectBuilder.java Mon Nov 11 15:42:59 2013
@@ -17,6 +17,8 @@
 
 package org.opensaml.saml.common;
 
+import javax.annotation.Nonnull;
+
 import org.opensaml.core.xml.AbstractXMLObjectBuilder;
 
 /**
@@ -32,5 +34,5 @@
      * 
      * @return built SAMLObject
      */
-    public abstract SAMLObjectType buildObject();
+    @Nonnull public abstract SAMLObjectType buildObject();
 }

Modified: trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectMarshaller.java
URL: http://svn.shibboleth.net/view/java-opensaml/trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectMarshaller.java?rev=3499&r1=3498&r2=3499&view=diff
==============================================================================
--- trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectMarshaller.java (original)
+++ trunk/opensaml-saml-api/src/main/java/org/opensaml/saml/common/AbstractSAMLObjectMarshaller.java Mon Nov 11 15:42:59 2013
@@ -24,8 +24,8 @@
 import org.w3c.dom.Element;
 
 /**
- * A thread safe, abstract implementation of the {@link org.opensaml.core.xml.io.Marshaller} interface that handles most of
- * the boilerplate code for Marshallers.

[... 439 lines stripped ...]