[java-identity-provider COMMIT] in /trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute: AttributeCont...

[noreply at shibboleth.net]

Author: rdw
Date: Wed May  1 06:56:10 2013
New Revision: 4437

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4437&view=rev
Log:
IDP-273 Apply coding guidance, mostly in the names of test methods.

Modified:
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeContextTest.java
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ByteAttributeValueTest.java
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/LocalizedStringAttributeValueTest.java
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/ScopedStringAttributeValueTest.java
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/StringAttributeValueTest.java
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/XMLObjectAttributeValueTest.java
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/logic/AttributeValuePredicateTest.java
    trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/logic/LookupAttributeFromAttributeContextFunctionTest.java

Modified: trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeContextTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeContextTest.java?rev=4437&r1=4436&r2=4437&view=diff
==============================================================================
--- trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeContextTest.java (original)
+++ trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeContextTest.java Wed May  1 06:56:10 2013
@@ -31,7 +31,7 @@
      * Test that the attributes from the supplied context cannot be modified
      * and that there as many as we expected. 
      */
-    private void testContextAttributes( AttributeContext context, int expectedSize) {
+    private void contextAttributes( AttributeContext context, int expectedSize) {
         Assert.assertEquals(context.getAttributes().size(), expectedSize);
         try {
             context.getAttributes().put("attr", new Attribute("attr") );
@@ -41,20 +41,20 @@
         }
     }
     
-    @Test public void testAttributeContext() {
+    @Test public void attributeContext() {
         AttributeContext context = new AttributeContext();
         
         context.setAttributes(Arrays.asList((Attribute)null, null));
-        testContextAttributes(context, 0);
+        contextAttributes(context, 0);
 
         context.setAttributes(Arrays.asList(new Attribute("foo"), null));
-        testContextAttributes(context, 1);
+        contextAttributes(context, 1);
         
         context.setAttributes(null);
-        testContextAttributes(context, 0);
+        contextAttributes(context, 0);
         
         context.setAttributes(Collections.EMPTY_SET);
-        testContextAttributes(context, 0);
+        contextAttributes(context, 0);
     }
 
 }

Modified: trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java?rev=4437&r1=4436&r2=4437&view=diff
==============================================================================
--- trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java (original)
+++ trunk/idp-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java Wed May  1 06:56:10 2013
@@ -36,7 +36,7 @@
 public class AttributeTest {
 
     /** Tests that the attribute has its expected state after instantiation. */
-    @Test public void testInstantiation() {
+    @Test public void instantiation() {
         Attribute attrib = new Attribute("foo");
 
         Assert.assertEquals(attrib.getId(), "foo");
@@ -59,7 +59,7 @@
     }
 
     /** Tests that null/empty IDs aren't accepted. */
-    @Test public void testNullEmptyId() {
+    @Test public void nullEmptyId() {
         try {
             new Attribute(null);
             Assert.fail("able to create attribute with null ID");
@@ -83,7 +83,7 @@
     }
 
     /** Tests that display names are properly added and modified. */
-    @Test public void testDisplayNames() {
+    @Test public void displayNames() {
         Locale en = new Locale("en");
         Locale enbr = new Locale("en", "br");
 
@@ -149,7 +149,7 @@
     }
 
     /** Tests that display descriptions are properly added and modified. */
-    @Test public void testDisplayDescriptions() {
+    @Test public void displayDescriptions() {
         Locale en = new Locale("en");
         Locale enbr = new Locale("en", "br");
 
@@ -215,7 +215,7 @@
     }
 
     /** Tests that values are properly added and modified. */
-    @Test public void testValues() {
+    @Test public void values() {
         LocalizedStringAttributeValue value1 = new LocalizedStringAttributeValue("value1", null);

[... 171 lines stripped ...]