[java-shib-common COMMIT] in /branches/REL_1: doc/RELEASE-NOTES.txt src/main/java/edu/internet2/middleware/shibboleth...

[noreply at shibboleth.net]

Author: scantor
Date: Mon Mar 25 18:00:41 2013
New Revision: 1068

URL: http://svn.shibboleth.net/view/java-shib-common?rev=1068&view=rev
Log:
SC-188: Errors in Velocity/SLF4J logging shim.

Modified:
    branches/REL_1/doc/RELEASE-NOTES.txt
    branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/common/util/Slf4JLogChute.java

Modified: branches/REL_1/doc/RELEASE-NOTES.txt
URL: http://svn.shibboleth.net/view/java-shib-common/branches/REL_1/doc/RELEASE-NOTES.txt?rev=1068&r1=1067&r2=1068&view=diff
==============================================================================
--- branches/REL_1/doc/RELEASE-NOTES.txt (original)
+++ branches/REL_1/doc/RELEASE-NOTES.txt Mon Mar 25 18:00:41 2013
@@ -4,6 +4,7 @@
 [SC-184] - Trap exceptions during LDAP connector pool inititalization
 [SC-186] -  AttributeInMetadata rule for the attribute filter (copied back from uApprove)
 [SC-187] - RequiredValidUntilFilter improperly converts duration to milliseconds
+[SC-188] - Errors in Velocity/SLF4J logging shim
 [SIDP-499] - Allow signed requests to bypass ACS verification
 [SIDP-559] - Attribute queries are ignoring input designators
 [SIDP-575] - Add option to omit NotBefore from assertion conditions

Modified: branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/common/util/Slf4JLogChute.java
URL: http://svn.shibboleth.net/view/java-shib-common/branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/common/util/Slf4JLogChute.java?rev=1068&r1=1067&r2=1068&view=diff
==============================================================================
--- branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/common/util/Slf4JLogChute.java (original)
+++ branches/REL_1/src/main/java/edu/internet2/middleware/shibboleth/common/util/Slf4JLogChute.java Mon Mar 25 18:00:41 2013
@@ -42,10 +42,10 @@
  */
 public class Slf4JLogChute implements LogChute {
 
-    /** Property key for specifying the name for the log instance */
+    /** Property key for specifying the name for the log instance. */
     public static final String LOGCHUTE_SLF4J_NAME = "runtime.log.logsystem.slf4j.name";
     
-    /** Default name for the commons-logging instance */
+    /** Default name for the commons-logging instance. */
     public static final String DEFAULT_LOG_NAME = "org.apache.velocity";
     
     /** The Slf4J Logger instance. */
@@ -84,6 +84,7 @@
         switch (level) {
             case LogChute.ERROR_ID:
                 log.error(message);
+                break;
             case LogChute.WARN_ID:
                 log.warn(message);
                 break;
@@ -104,6 +105,7 @@
         switch (level) {
             case LogChute.ERROR_ID:
                 log.error(message, t);
+                break;
             case LogChute.WARN_ID:
                 log.warn(message, t);
                 break;