[java-identity-provider COMMIT] /trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/IdpInit...
noreply at shibboleth.net
noreply at shibboleth.net
Thu Mar 7 22:23:58 EST 2013
Author: tzeller
Date: Thu Mar 7 22:23:58 2013
New Revision: 4314
URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4314&view=rev
Log:
Not sure where we should initialize the decoder, this class or ?
Modified:
trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/IdpInitiatedSsoDecoderFactory.java
Modified: trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/IdpInitiatedSsoDecoderFactory.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/IdpInitiatedSsoDecoderFactory.java?rev=4314&r1=4313&r2=4314&view=diff
==============================================================================
--- trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/IdpInitiatedSsoDecoderFactory.java (original)
+++ trunk/idp-saml-impl/src/main/java/net/shibboleth/idp/saml/impl/profile/saml1/IdpInitiatedSsoDecoderFactory.java Thu Mar 7 22:23:58 2013
@@ -25,6 +25,7 @@
import net.shibboleth.idp.profile.HttpServletRequestMessageDecoderFactory;
import net.shibboleth.idp.saml.impl.profile.BaseIdpInitiatedSsoRequestMessageDecoder;
import net.shibboleth.idp.saml.impl.profile.saml1.IdpInitiatedSsoDecoderFactory.IdpInitatedSsoRequest;
+import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
import net.shibboleth.utilities.java.support.logic.Constraint;
import net.shibboleth.utilities.java.support.primitive.StringSupport;
@@ -44,6 +45,12 @@
public MessageDecoder newDecoder(HttpServletRequest httpRequest) throws MessageDecodingException {
IdpInitiatedSsoRequestMessageDecoder decoder = new IdpInitiatedSsoRequestMessageDecoder();
decoder.setHttpServletRequest(httpRequest);
+ // TODO should we initialize the decoder here ?
+ try {
+ decoder.initialize();
+ } catch (ComponentInitializationException e) {
+ throw new MessageDecodingException("Unable to initialize message decoder", e);
+ }
return decoder;
}
More information about the commits
mailing list