[java-identity-provider COMMIT] /trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver...

[noreply at shibboleth.net]

Author: rdw
Date: Mon Jun  3 04:52:19 2013
New Revision: 4505

URL: http://svn.shibboleth.net/view/java-identity-provider?rev=4505&view=rev
Log:
Check Brent's refactoring and strip the TODO to get that done.

Modified:
    trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseSubjectNamePrincipalConnectorDefinition.java

Modified: trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseSubjectNamePrincipalConnectorDefinition.java
URL: http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseSubjectNamePrincipalConnectorDefinition.java?rev=4505&r1=4504&r2=4505&view=diff
==============================================================================
--- trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseSubjectNamePrincipalConnectorDefinition.java (original)
+++ trunk/idp-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/BaseSubjectNamePrincipalConnectorDefinition.java Mon Jun  3 04:52:19 2013
@@ -58,8 +58,6 @@
     private Set<String> relyingParties = Collections.EMPTY_SET;
 
     /**
-     * TODO - verify that this is correct going forward.
-     * 
      * The strategy to resolve the message context containing the SAML message being processed.
      */
     private Function<AttributeResolutionContext, MessageContext<SAMLObject>> contextFinderStrategy;
@@ -103,8 +101,6 @@
     }
 
     /**
-     * TODO - verify that this is correct going forward.
-     * 
      * Function to set up the context navigation mechanism. This is used to go from a
      * {@link AttributeResolutionContext} to a {@link MessageContext} containing a SAML protocol message represented by
      * a {@link SAMLObject}.
@@ -147,8 +143,6 @@
     }
 
     /**
-     * TODO - verify that this is correct going forward.
-     * 
      * Helper function to find the IssuerId ("entityID of SP") for this message. This allow the attribute resolver to
      * not be involved in the required navigation.
      * 
@@ -161,8 +155,6 @@
     }
 
     /**
-     * TODO - verify that this is correct going forward.
-     * 
      * Helper function to find the format (from the {@link NameID} or {@link NameIdentifier}) for this message. This
      * allow the attribute resolver to not be involved in the required navigation.
      * 
@@ -186,8 +178,6 @@
     }
 
     /**
-     * TODO - verify that this is correct going forward.
-     * 
      * Helper function to find the context (from the {@link NameID} or {@link NameIdentifier}) for this message. The
      * superclasses may use this to do the lookup.
      *